fix: normalize path separators in git submodule URL lookup #11826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wellnana
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg,
yash-atreya and
zerosnacks
as code owners
yash-atreya
suggested changes
Sep 26, 2025
There was a problem hiding this comment.
@wellnana Can we use dunce::canonicalize on the paths returned here: https://github.com/wellnana/foundry/blob/85587aa848a5cbddf5720495583e1551e40a2f05/crates/forge/src/cmd/remove.rs#L34
yash-atreya
previously requested changes
Sep 26, 2025
onbjerg
previously requested changes
Sep 29, 2025
|
Thanks for the review @onbjerg ! I've updated the code per your suggestions - removed the path separator replacement and now rely only on |
|
doesn't seem to work |
DaniPopes
reviewed
Sep 30, 2025
crates/forge/src/cmd/remove.rs
Outdated
| pub fn run(self) -> Result<()> { | ||
| let config = self.load_config()?; | ||
| let (root, paths, _) = super::update::dependencies_paths(&self.dependencies, &config)?; | ||
| let (root, mut paths, _) = super::update::dependencies_paths(&self.dependencies, &config)?; |
There was a problem hiding this comment.
shouldn't this be done inside of the function?
|
issue here is that the command should be > git config --get submodule.lib/forge-std.url
https://github.com/foundry-rs/forge-stdbut on win path was git config --get submodule.lib\forge-std.urlreturned nothing |
onbjerg
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git always uses forward slashes in submodule config keys, even on Windows, so we need to normalize the path separators before looking up the URL.
This also fixed flaky test.
Might be the reason why the test is failing during #11437 (review) cc @onbjerg