Skip to content

Conversation

ddoktorski
Copy link
Contributor

@ddoktorski ddoktorski commented Aug 22, 2025

Closes #3658

commit-id:5ba0cf9f


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@ddoktorski ddoktorski requested a review from a team as a code owner August 22, 2025 10:04
@ddoktorski ddoktorski requested review from cptartur and MKowalski8 and removed request for a team August 22, 2025 10:04
@ddoktorski
Copy link
Contributor Author

Note: This change hasn’t been tested in detail at this point, aside from a basic sanity check comparing gas_consumed in the trace for the same test before and after the change. The comparison was not thorough, it only verified whether the gas value increased significantly, which it did. This is expected as the cost of the call_contract_syscall is now included, whereas it was not tracked previously.

Proper testing will be done as part of #3292. It is expected to work as intended if the current gas values in tests do not require changes or only minor adjustments.

@ddoktorski ddoktorski requested a review from cptartur August 25, 2025 12:16
github-merge-queue bot pushed a commit that referenced this pull request Aug 25, 2025
Related #3658

commit-id:9aa72e2d

---

**Stack**:
- #3672
- #3664
- #3663⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/master/9aa72e2d to master August 25, 2025 12:24
@ddoktorski ddoktorski force-pushed the spr/master/5ba0cf9f branch from e1cbb60 to a729bf6 Compare August 25, 2025 12:39
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replied to comments

@ddoktorski ddoktorski force-pushed the spr/master/5ba0cf9f branch from a729bf6 to bc8db3e Compare August 26, 2025 13:35
@ddoktorski ddoktorski requested a review from cptartur August 26, 2025 13:35
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one reply, but otherwise looks good

@ddoktorski ddoktorski added this pull request to the merge queue Aug 27, 2025
Merged via the queue into master with commit d146920 Aug 27, 2025
95 of 100 checks passed
@ddoktorski ddoktorski deleted the spr/master/5ba0cf9f branch August 27, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update remaining gas in CallToBlockifierRuntime
3 participants