Remove deploy cheatnet tests
#3675
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddoktorski
requested review from
cptartur and
MKowalski8
and removed request for
a team
ddoktorski
force-pushed
the
spr/master/a6d72598
branch
2 times, most recently
from
b04b0dc to
f83207c
Compare
ddoktorski
force-pushed
the
spr/master/012afbae
branch
from
6acbf3d to
3586a93
Compare
franciszekjob
approved these changes
Aug 27, 2025
ddoktorski
force-pushed
the
spr/master/012afbae
branch
from
3586a93 to
63fb727
Compare
ddoktorski
force-pushed
the
spr/master/a6d72598
branch
from
f83207c to
2bfbd44
Compare
cptartur
reviewed
Aug 28, 2025
| @@ -189,6 +192,41 @@ pub fn deploy_at_wrapper( | |||
| Ok(contract_address) | |||
| } | |||
|
|
|||
| fn deploy_helper( | |||
There was a problem hiding this comment.
Why do we need this helper, doesn't this mean we are effectively testing the logic of the helper instead?
There was a problem hiding this comment.
At this point it is kind of in between, but in #3695 it is used only as a setup for cheatnet tests
There was a problem hiding this comment.
Let's make sure it's only used for setup then.
Towards #3659 commit-id:a6d72598
ddoktorski
force-pushed
the
spr/master/a6d72598
branch
from
2bfbd44 to
9f041d9
Compare
ddoktorski
changed the title
deploy cheatnet tests
ddoktorski
force-pushed
the
spr/master/012afbae
branch
from
63fb727 to
5b60eb3
Compare
cptartur
approved these changes
Aug 29, 2025
| @@ -189,6 +192,41 @@ pub fn deploy_at_wrapper( | |||
| Ok(contract_address) | |||
| } | |||
|
|
|||
| fn deploy_helper( | |||
There was a problem hiding this comment.
Let's make sure it's only used for setup then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3659
Stack:
CallInfo#3700integration::gastests #3699deploy_atcheatnet tests #3695deploy_atas cheatcode #3676deploycheatnet tests #3675 ⬅deployas cheatcode #3674