Skip to content

Column name disambiguation in closure table queries #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Column name disambiguation in closure table queries #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Models/Entity.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,12 +430,12 @@ private function buildAncestorsQuery(Builder $builder, $id, $withSelf)
return $builder
->join(
$this->closure->getTable(),
$this->closure->getAncestorColumn(),
$this->closure->getQualifiedAncestorColumn(),
'=',
$this->getQualifiedKeyName()
)
->where($this->closure->getDescendantColumn(), '=', $id)
->where($this->closure->getDepthColumn(), $depthOperator, 0);
->where($this->closure->getQualifiedDescendantColumn(), '=', $id)
->where($this->closure->getQualifiedDepthColumn(), $depthOperator, 0);
}

/**
Expand Down Expand Up @@ -563,12 +563,12 @@ private function buildDescendantsQuery(Builder $builder, $id, $withSelf)
return $builder
->join(
$this->closure->getTable(),
$this->closure->getDescendantColumn(),
$this->closure->getQualifiedDescendantColumn(),
'=',
$this->getQualifiedKeyName()
)
->where($this->closure->getAncestorColumn(), '=', $id)
->where($this->closure->getDepthColumn(), $depthOperator, 0);
->where($this->closure->getQualifiedAncestorColumn(), '=', $id)
->where($this->closure->getQualifiedDepthColumn(), $depthOperator, 0);
}

/**
Expand Down
5 changes: 5 additions & 0 deletions tests/migrations/2014_01_18_162506_create_entities_table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ public function up()
$table->integer('position', false, true);
$table->softDeletes();

// Ensures there are no ambiguous column names in queries involving the closure table
$table->integer('ancestor')->nullable();
$table->integer('descendant')->nullable();
$table->integer('depth')->nullable();

$table->foreign('parent_id')->references('id')->on('entities')->onDelete('set null');

$table->engine = 'InnoDB';
Expand Down