feat: add NotFound variant to ContractResponse #45
+232
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit NotFound response type to the client API to distinguish "contract not found" from other failure modes like timeouts. Changes: - Add NotFound table to FlatBuffers schema with instance_id field - Add NotFound variant to ContractResponse enum - Update into_fbs_bytes to serialize NotFound - Update Display impl to handle NotFound - Regenerate flatbuffers with flatc 24.3.25 for compatibility - Bump version to 0.1.29 This enables freenet-core to return ContractResponse::NotFound when a GET or SUBSCRIBE operation determines that a contract doesn't exist after exhaustive search, rather than returning a generic error. Closes #2368 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add explicit
NotFoundresponse type to the client API to distinguish "contract not found" from other failure modes like timeouts.Changes
NotFoundtable to FlatBuffers schema withinstance_idfieldNotFoundvariant toContractResponseenuminto_fbs_bytesto serializeNotFoundDisplayimpl to handleNotFoundContext
This enables freenet-core to return
ContractResponse::NotFoundwhen a GET or SUBSCRIBE operation determines that a contract doesn't exist after exhaustive search, rather than returning a generic error.Related: freenet/freenet-core#2368
Testing
🤖 Generated with Claude Code