Re-add Changes Lost From #4272

[1eyewonder]

This PR is re-adding some code that was lost from #4272 when code was getting bumped for various v9 things. If this code was purposefully removed, feel free to close this PR but I didn't see anything obvious as to why it may have been removed. I figured I would keep it at net8 for now since that was previously approved. We can then work on doing any net9 updates desired in later PRs

[1eyewonder]

Paket Lock Diff Report

This report was generated via Paket Lock Diff

Additions - (0)

Removals - (5)

• FSharpDepManagerExtension - (1)

  • FSharp.Core - 5.0.0

• Main - (4)

  • Microsoft.NETCore.App - 2.2.8
  • Microsoft.NETCore.DotNetAppHost - 3.1.8
  • Microsoft.NETCore.DotNetHostPolicy - 3.1.8
  • Microsoft.NETCore.DotNetHostResolver - 3.1.8

Version Upgrades - (2)

• Main - (2)
  • Minor - (1)
    • FSharp.Compiler.Service - 43.8.400 -> 43.9.101
  • Major - (1)
    • FSharp.Core - 8.0.400 -> 9.0.101

Version Downgrades - (0)

[1eyewonder]

I believe these changes should be good to go. The failing tests seemed normal as mentioned in the discussion on #4272. Let me know if I can update anything else 😄

[smoothdeveloper]

@1eyewonder, could you check those:

• keeping at least the target list formatted as it was in build.fsx
• setting framework restrictions framework: >= net461, >= net8.0 in the paket.dependencies in case it removes some bloat in the .lock file
• seeing if we should remove the other redirects: force (I assume it is pointless given executables are ilmerged)

Thanks for the updates.

[1eyewonder]

@smoothdeveloper Sorry, I had VSCode set to format on save! Made all the necessary changes. Good call on the framework restrictions 😎

[1eyewonder]

Actually spoke too soon. Looking into some errors

[smoothdeveloper]

Sorry, framework restrictions work without :

framework >= net461, >= net80

[1eyewonder]

Paket Lock Diff Report

This report was generated via Paket Lock Diff

Additions - (0)

Removals - (46)

• FSharpDepManagerExtension - (1)

  • FSharp.Core - 5.0.0

• Main - (45)

  • Microsoft.CSharp - 4.7.0
  • Microsoft.NETCore.App - 2.2.8
  • Microsoft.NETCore.DotNetAppHost - 3.1.8
  • Microsoft.NETCore.DotNetHostPolicy - 3.1.8
  • Microsoft.NETCore.DotNetHostResolver - 3.1.8
  • runtime.debian.8-x64.runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • runtime.debian.9-x64.runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • runtime.fedora.23-x64.runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • runtime.fedora.24-x64.runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • runtime.fedora.27-x64.runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • runtime.fedora.28-x64.runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • runtime.native.System.IO.Compression - 4.3.2
  • runtime.native.System.Net.Http - 4.3.1
  • runtime.native.System.Security.Cryptography.Apple - 4.3.1
  • runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • runtime.opensuse.13.2-x64.runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • runtime.opensuse.42.1-x64.runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • runtime.opensuse.42.3-x64.runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.Apple - 4.3.1
  • runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • runtime.rhel.7-x64.runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • runtime.ubuntu.14.04-x64.runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • runtime.ubuntu.16.04-x64.runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • runtime.ubuntu.16.10-x64.runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • runtime.ubuntu.18.04-x64.runtime.native.System.Security.Cryptography.OpenSsl - 4.3.3
  • System.Collections.Concurrent - 4.3.0
  • System.Console - 4.3.1
  • System.Diagnostics.Tools - 4.3.0
  • System.Diagnostics.Tracing - 4.3.0
  • System.Globalization.Calendars - 4.3.0
  • System.IO.Compression - 4.3.0
  • System.IO.Compression.ZipFile - 4.3.0
  • System.Net.Http - 4.3.4
  • System.Net.Primitives - 4.3.1
  • System.Net.Sockets - 4.3.0
  • System.Runtime.Numerics - 4.3.0
  • System.Runtime.Serialization.Formatters - 4.3.0
  • System.Runtime.Serialization.Primitives - 4.3.0
  • System.Security.Claims - 4.3.0
  • System.Security.Cryptography.Csp - 4.3.0
  • System.Security.Cryptography.OpenSsl - 4.7.0
  • System.Security.Cryptography.X509Certificates - 4.3.2
  • System.Security.Principal - 4.3.0
  • System.Threading.Timer - 4.3.0
  • System.Xml.XDocument - 4.3.0

Version Upgrades - (3)

• Main - (3)
  • Minor - (1)
    • FSharp.Compiler.Service - 43.8.400 -> 43.9.101
  • Major - (1)
    • FSharp.Core - 8.0.400 -> 9.0.101
  • Patch - (1)
    • Newtonsoft.Json - 13.0.1 -> 13.0.3

Version Downgrades - (0)

[1eyewonder]

@smoothdeveloper It appears adding the framework restrictions and removing the Newtonsoft redirect is causing build issues on the build server. Have any ideas as to what the errors could mean? I'm interpreting this as a FAKE build issue but I could be wrong

[Numpsy]

@smoothdeveloper It appears adding the framework restrictions and removing the Newtonsoft redirect is causing build issues on the build server. Have any ideas as to what the errors could mean? I'm interpreting this as a FAKE build issue but I could be wrong

Does it work to set a framework restriction of >= net461, >= net80 when Paket.Core is built as .NET Standard 2.0? (I mean, does it need to include netstandard2.0 in the restriction as well?)

[smoothdeveloper]

@Numpsy, AFAIU, it is about the package resolution that relies only on package metadata; not reliant on the runtime paket executable is running.

I need to look at the branch again and see if the tweaks I suggested are worth anything / what is causing the issue with CI.

[Numpsy]

I'm not sure, but if I build this branch locally I get the same error and then the netstandard2.0 paket file here is empty:

and Rider shows the .NET Standard build of Paket.Core as having no NuGet dependencies.

If I add netstandard2.0 to the framework list, then it seems to work.

[1eyewonder]

I ended up reverting the changes involving the framework restrictions in the paket.dependencies since they were causing issues in the CI at the moment. I'd say we try to tackle the issue in another PR since this gets the code back in which appeared to be accidentally removed. I think this should be good to go, but let me know if people think otherwise.

[1eyewonder]

Here is the paket.lock diff after reverting the changes

Paket Lock Diff Report

This report was generated via Paket Lock Diff

Additions - (0)

Removals - (5)

• FSharpDepManagerExtension - (1)

  • FSharp.Core - 5.0.0

• Main - (4)

  • Microsoft.NETCore.App - 2.2.8
  • Microsoft.NETCore.DotNetAppHost - 3.1.8
  • Microsoft.NETCore.DotNetHostPolicy - 3.1.8
  • Microsoft.NETCore.DotNetHostResolver - 3.1.8

Version Upgrades - (2)

• Main - (2)
  • Minor - (1)
    • FSharp.Compiler.Service - 43.8.400 -> 43.9.101
  • Major - (1)
    • FSharp.Core - 8.0.400 -> 9.0.101

Version Downgrades - (0)

[Numpsy]

Has the CI stopped running for pull requests?