Add lillipop-h chart #136
Open
Add lillipop-h chart #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aendra-rininsland
requested changes
Apr 27, 2018
Member
aendra-rininsland
left a comment
aendra-rininsland
left a comment
There was a problem hiding this comment.
Looks pretty good, few minor changes.
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <title>Bar chart - Visual Vocabulary</title> |
| <title>Bar chart - Visual Vocabulary</title> | ||
| <script src="//unpkg.com/@financial-times/d3-bootloader" async></script> | ||
| <link rel="stylesheet" href="https://ig.ft.com/visual-vocabulary/styles.css"/> | ||
| <link rel="stylesheet" href="./bar.css"/> |
Member
There was a problem hiding this comment.
This no longer exists and is throwing 404s
| </head> | ||
| <body> | ||
|
|
||
| <h1>Bar and grouped bar chart</h1> |
| source: 'Source not yet added', | ||
| }; | ||
|
|
||
| const xMin = -0;// sets the minimum value on the yAxis |
| } else { | ||
| stalks = false; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
The above two conditionals could be replaced with two expressions:
const dots = dotWidth > 0;
const stalks = stalkWidth > 0;
|
|
||
|
|
||
|
|
||
|
|
Member
There was a problem hiding this comment.
Remove some of this extraneous whitespace
Member
|
Also, please name folders in lowercase and kebab-case. I.e., rename this to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.