Skip to content

Allow the messages to be overridable. #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow the messages to be overridable. #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions fsm_admin/mixins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ class FSMTransitionMixin(object):
fsm_field = ['state']
change_form_template = 'fsm_admin/change_form.html'
default_disallow_transition = not getattr(settings, 'FSM_ADMIN_FORCE_PERMIT', False)
success_message_template = _('%(obj)s successfully set to %(new_state)s')
error_message_template = _('Error! %(obj)s failed to %(transition)s')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a trailing dot here by default (since it is a whole sentence), but this might cause translations to become outdated etc, so maybe better to keep it as before by default.
(However the missing dot would be the only reason to override/customize it for me)


def _fsm_get_transitions(self, obj, request, perms=None):
"""
Expand Down Expand Up @@ -98,9 +100,9 @@ def response_change(self, request, obj):
return super(FSMTransitionMixin, self).response_change(request, obj)

if obj._fsmtransition_results['status'] == messages.SUCCESS:
msg = _('%(obj)s successfully set to %(new_state)s') % obj._fsmtransition_results
msg = self.success_message_template % obj._fsmtransition_results
else:
msg = _('Error! %(obj)s failed to %(transition)s') % obj._fsmtransition_results
msg = self.error_message_template % obj._fsmtransition_results

self.message_user(request, msg, obj._fsmtransition_results['status'])

Expand Down