-
Notifications
You must be signed in to change notification settings - Fork 15
Issue 5480 - DataFusion CLI tests #5487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patchwork01
approved these changes
Aug 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine assuming the intention of the issue was just for the validation of command line arguments.
I've commented on the PR this is stacked on about testing the implementation.
Note that we can't merge this until the base PR is merged.
…0-Query-CLI-tests
…0-Query-CLI-tests
…0-Query-CLI-tests
…0-Query-CLI-tests
…0-Query-CLI-tests
…0-Query-CLI-tests
…0-Query-CLI-tests
…0-Query-CLI-tests
…0-Query-CLI-tests
…0-Query-CLI-tests
…0-Query-CLI-tests
Base automatically changed from
5408-implement-rust-leaf-partition-query-code
to
develop
September 5, 2025 08:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-stacked-middle
A stacked pull request that must wait until the target PR is merged, and is also a base for stacking
rust
Pull requests that update Rust code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Issue
Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
for your progress.
Tests
Documentation
separate issue for that below.