Skip to content

Conversation

m09526
Copy link
Member

@m09526 m09526 commented Aug 14, 2025

Make sure you have checked all steps below.

Issue

  • My PR fully resolves the following issues. I've referenced an issue in the PR title, for example "Issue 1234 - My
    Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
    for your progress.

Tests

  • My PR adds the following tests based on our test strategy OR does not need testing for this extremely good reason:
    • Unit tests for query clil debugging tool

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added new Java code, I have added Javadoc that explains it following our conventions and style.
  • If I have added or removed any dependencies from the project, I have updated the NOTICES file.

@m09526 m09526 self-assigned this Aug 14, 2025
@m09526 m09526 linked an issue Aug 14, 2025 that may be closed by this pull request
@m09526 m09526 changed the base branch from develop to 5408-implement-rust-leaf-partition-query-code August 14, 2025 09:45
@m09526 m09526 added pr-stacked-middle A stacked pull request that must wait until the target PR is merged, and is also a base for stacking rust Pull requests that update Rust code labels Aug 14, 2025
@patchwork01 patchwork01 added pr-stacked-top A stacked pull request that we don't want to merge into its target until the target PR is merged and removed pr-stacked-middle A stacked pull request that must wait until the target PR is merged, and is also a base for stacking labels Aug 14, 2025
Copy link
Collaborator

@patchwork01 patchwork01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine assuming the intention of the issue was just for the validation of command line arguments.

I've commented on the PR this is stacked on about testing the implementation.

Note that we can't merge this until the base PR is merged.

@m09526 m09526 added pr-stacked-middle A stacked pull request that must wait until the target PR is merged, and is also a base for stacking and removed pr-stacked-top A stacked pull request that we don't want to merge into its target until the target PR is merged labels Aug 20, 2025
@m09526 m09526 marked this pull request as draft September 1, 2025 16:08
@m09526 m09526 marked this pull request as ready for review September 2, 2025 16:23
Base automatically changed from 5408-implement-rust-leaf-partition-query-code to develop September 5, 2025 08:53
@patchwork01 patchwork01 merged commit 2228d00 into develop Sep 5, 2025
4 checks passed
@patchwork01 patchwork01 deleted the 5480-Query-CLI-tests branch September 5, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-stacked-middle A stacked pull request that must wait until the target PR is merged, and is also a base for stacking rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write some tests for DataFusion query CLI
3 participants