Skip to content

Conversation

@nikohl-de
Copy link
Contributor

No description provided.

@nikohl-de nikohl-de requested a review from cybernop September 25, 2025 13:36
@nikohl-de
Copy link
Contributor Author

@cybernop: Das mit dem Löschen von Packages gestaltet sich doch noch schwieriger als gedacht. Problem ist, dass ich entweder beim Löschen auch direkt die in-memory Mappings und Comparisons entfernen müsste. Leider ist mir da die Datenstruktur nicht so wirklich geläufig, weshalb ich es dann mit einem Neuladen der config.json probiert habe. Das scheint relativ langsam zu sein, funktioniert aber generell.

Copy link
Contributor

@cybernop cybernop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should discuss about how we should delete. IMO we should only allow deleting a package if it is not used in a mapping or comparison. In that way the user needs to check if the package is used and explicitly remove those comparisons and mappings.

Also please fix the formatting the check complained about :)

@cybernop
Copy link
Contributor

Further improvements of the checks will be done in #20

@nikohl-de nikohl-de merged commit f31b6b9 into main Dec 4, 2025
1 check passed
@nikohl-de nikohl-de deleted the feature/add-delete-endpoint-mapping-package branch December 4, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants