-
Notifications
You must be signed in to change notification settings - Fork 17
feat(tasks): add support for Google Tasks #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @allenhutchison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the system's capabilities by integrating full support for Google Tasks. It introduces a dedicated service and a comprehensive set of tools that enable users to programmatically manage their task lists and individual tasks, from creation and listing to updating and deletion. This enhancement allows for more robust task management workflows within the existing framework. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds comprehensive support for Google Tasks, including a new TasksService, corresponding API client logic in AuthManager, and registration of several new tools. The implementation is well-structured and includes a good set of tests. My review includes a few suggestions to improve test coverage and enhance consistency and conciseness in the service implementation.
| await tasksService.completeTask({ taskListId: 'list1', taskId: 'task1' }); | ||
|
|
||
| expect(mockTasksClient.tasks.patch).toHaveBeenCalledWith({ | ||
| tasklist: 'list1', | ||
| task: 'task1', | ||
| requestBody: { | ||
| status: 'completed', | ||
| } | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test for completeTask verifies that the patch method is called with the correct arguments, but it doesn't check the return value of completeTask. For consistency with other tests in this file (like updateTask), you should also assert that the returned result is correct.
const result = await tasksService.completeTask({ taskListId: 'list1', taskId: 'task1' });
expect(mockTasksClient.tasks.patch).toHaveBeenCalledWith({
tasklist: 'list1',
task: 'task1',
requestBody: {
status: 'completed',
}
});
expect(result).toEqual({
content: [{ type: 'text', text: JSON.stringify(mockResponse.data, null, 2) }],
});Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Adds full support for Google Tasks.
TasksServiceto interact with the Google Tasks API.tasks.listLists: List task lists.tasks.list: List tasks in a list (supports filtering and assigned tasks).tasks.create: Create new tasks.tasks.update: Update existing tasks.tasks.complete: Mark tasks as completed.tasks.delete: Delete tasks.AuthManagerto includetasksscope.Fixes #105