Fix code QL security issues #1231
Merged
+20
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
claudiamurialdo
commented
Dec 1, 2025
claudiamurialdo
commented
- Added a timeout to the Regex constructor to prevent potential Regular Expression Denial of Service (ReDoS).
- Sanitized the user-provided filename in GetBinary.
- Improved debug logging in GXMetadata.cs by logging class names instead of constructor arguments, and removed ConstructorArgsString to prevent unsanitized user input from being written to log files.
- Issue:206598
- Added a timeout to the Regex constructor to prevent potential Regular Expression Denial of Service (ReDoS). - Sanitized the user-provided filename in GetBinary. - Improved debug logging in GXMetadata.cs by logging class names instead of constructor arguments, and removed ConstructorArgsString to prevent unsanitized user input from being written to log files.
claudiamurialdo
changed the title
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta failed, 1 conflicted file in commit 2c97906
|
Collaborator
Manual cherry pick to beta success |
sgrampone
previously approved these changes
Dec 2, 2025
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.