Add safety around font parameters #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue : The `getFontParameters` function can return `null`, and the current implementation is not guaranteed to return an item. This cause issues when there are label that need to be printed. Fix : We add the font size in the default font string (as it is necessary to the regex). We also ensure we have default values in case the regex within `getFontParameters` does not manage to parse anything (for example, it can't parse numbers in font names)
gberaudo
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : The
getFontParametersfunction can returnnull, and the current implementation is not guaranteed to return an item. This cause issues when there are label that need to be printed.Fix : We add the font size in the default font string (as it is necessary to the regex). We also ensure we have default values in case the regex within
getFontParametersdoes not manage to parse anything (for example, it can't parse numbers in font names)