(v5) Overlay system #1470
Draft
(v5) Overlay system #1470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most (if not all) mods that use keepAcrossScenes try to keep their node above the current scene, so why not just have an overlay to make that easier? I've added an overlay that gets visited after the CCScene, so it'll always render above and won't have weirdness moving the node between changing CCScenes.
I also have a fork of DevTools prepared which renders the overlay node below the CCScene.
Marked as draft as it contains breaking changes and should only be merged with geode v5.
Credit to Alphalaneous for the idea on how to implement this!