Upgrade to eslint 9 #938
Open
Upgrade to eslint 9 #938
+10,136
−13,402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires a new configuration file format. Plugins are no longer used, instead packages provide recommended configuration. ESLint suggests using a separate formatter, and since we already use prettier, I've removed the (now unsupported) stylistic rules.
|
|
|
Integration tests report: appsharing.space |
Can you elaborate a bit? Do you mean the required GitHub labels like |
See: jupyterlab/jupyterlab#17913 I'd love to switch to pnpm :) |
|
I'm finding it difficult to adjust to the ESLint 9 config! I have a few concerns I wasn't able to resolve in my available time today, and I'd appreciate your thoughts:
|
mfisher87
reviewed
Sep 30, 2025
| export default defineConfig([ | ||
| { | ||
| languageOptions: { | ||
| parserOptions: { |
There was a problem hiding this comment.
Should we be setting the parser?
Suggested change
| parserOptions: { | |
| parser: ..., | |
| parserOptions: { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires a new configuration file format. Plugins are no longer used, instead packages provide recommended configuration.
ESLint suggests using a separate formatter, and since we already use prettier, I've removed the (now unsupported) stylistic rules.
xref: #933 (comment)
If you are happy with this configuration, I can go ahead and fix the few outstanding issues found by eslint.
One note I didn't put in the commit message: the version of
rimrafused is now deprecated, so I updated that dependency too (new, but not too new 😉).Process notes
It would be easier to find the relevant category labels if they were prefixed by, e.g.,
type:.I noticed that
yarnwas noticeably slower thanpnpmto install dependencies; perhaps something to pay attention to long-term.Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--938.org.readthedocs.build/en/938/
💡 JupyterLite preview: https://jupytergis--938.org.readthedocs.build/en/938/lite