Skip to content

Conversation

@gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Nov 19, 2025

Description

Adds story maps.
(This is still a rough draft version)

Users can now add landmarks (which are technically a layer) consisting of a map extent, zoom level, and the content to be displayed.

Currently there is a Story Editor panel, where you can change the title of the story, the type of story (guided or unguided), and the landmarks for the story, and a button to toggle the story viewer panel.

The story viewer panel shows the content of the landmark, so the title, an image, and the actual markdown content.

There's also a new setting for 'presentation mode' you can set that hides unnecessary side panel tabs and the story editor view.

Obviously the preview button is terrible and not going to stay there but I don't know where to put it. I was thinking either a toggle switch thing in the top left corner of the panel, or getting rid of the story editor panel (I really doubt anyone want to edit UUIDs manually 😆 ) and moving the story type selector somewhere else.

story_maps.mp4

TODO:

  1. Scrollytelling

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--994.org.readthedocs.build/en/994/
💡 JupyterLite preview: https://jupytergis--994.org.readthedocs.build/en/994/lite

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/add_landmarks_as_layer

@martinRenou martinRenou changed the title Add landmarks as layer Add story maps Nov 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

Integration tests report: appsharing.space

@gjmooney gjmooney added the enhancement New feature or request label Nov 19, 2025
@gjmooney gjmooney marked this pull request as ready for review November 19, 2025 16:12
@mfisher87
Copy link
Member

Demo looks great! I would love to have more time to help with a code review... sprinting for a workshop at a huge conference coming up. :( From the demo, the transition speed is really fast. What do you think of reducing it so that users have a better sense of where they are moving? Eventually, I'd love to have that fully configurable by the user, but that feels like a future PR :)

@gjmooney
Copy link
Collaborator Author

CC @mfisher87 I added some options to change the animation duration and style, not sure about 'smooth' as a name though

animations.mp4

@mfisher87
Copy link
Member

Nice! Thanks, Greg! For the future, what do you think of being able to set transition settings for each individual landmark?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants