feat: Pass custom headers to tile server requests #266
+349
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> contextily/tests/test_cx.py:806: RuntimeWarning: More than 20 figures have been opened. Figures created through the pyplot interface (`matplotlib.pyplot.figure`) are retained until explicitly closed and may consume too much memory. (To control this warning, see the rcParam `figure.max_open_warning`). Consider using `matplotlib.pyplot.close()`.
Author
Author
|
This also removes an unrelated matplotlib pytest warning ( ad65bcb ). |
jthetzel
force-pushed
the
request-headers
branch
from
d9a1ebe to
e4c2ee5
Compare
martinfleis
reviewed
Nov 24, 2025
Member
martinfleis
left a comment
martinfleis
left a comment
There was a problem hiding this comment.
Thanks! I think this approach is fine. Just one comment - can we catch a situation when a user passes custom user-agent in headers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows contextily users to pass an optional
headersparameter that will be included in the_retryerfunction'srequest.getcall to the tile server.We use titiler with cloud optimized geotiffs for tiles and often authenticate the titiler server with an authentication bearer token in the http request headers. This change allows us to use contextily with our authenticated titiler.
Opening this pull request for discussion in case it is of use to others. Please let me know if there is a simpler way to use contextily with custom headers.
Related issue: #267