Skip to content

Conversation

@tomkralidis
Copy link
Member

No description provided.

@tomkralidis
Copy link
Member Author

CI failures are unrelated (pygeoapi EDR 500 error and OGC API - Connected Systems error (to be addressed by #1013).

@tomkralidis tomkralidis changed the title increase contact parsing increase ISO contact parsing Oct 18, 2025
@kalxas kalxas merged commit b731470 into master Oct 18, 2025
0 of 6 checks passed
@kalxas kalxas deleted the fix-iso-contact-re branch October 18, 2025 09:56
@pvgenuchten
Copy link
Contributor

pvgenuchten commented Oct 27, 2025

hi tom, can you explain what this code aims to do?

for ct in ['creator', 'publisher', 'contributor']:
                iict = getattr(ii, ct)
                if iict:
                    for iict2 in iict:
                        contacts.append(iict2)

code expects ii (identificationInfo) to have a property called 'creator','publ' or 'cont'? this is quite unexpected, when does it happen? it's not in the gmd schema

@tomkralidis
Copy link
Member Author

contributor

owslib.iso.MD_DataIdentification and owslib.iso3.MD_DataIdentification have creator, publisher, contributor members (lists) (note that ISO3 additionally includes funder). These are populated on parsing if they exist (as CI_RoleCode values).

In summary, owslib.iso and owslib.iso3 get_all_contacts is convenience function which attempts to capture all contacts in an ISO document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants