Skip to content

fix: Better Auth 1.4 support #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ARLBR10 wants to merge 2 commits into
base: main
Choose a base branch
from
+28 −27
Open

fix: Better Auth 1.4 support #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c62e3a
fix: Passkey error on better auth 1.4
ARLBR10 Dec 7, 2025
3444088
chore: Update dependecies
ARLBR10 Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 27 additions & 26 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,53 +93,54 @@
}
},
"peerDependencies": {
"better-auth": "1.3.34",
"better-auth": "1.4.5",
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The peerDependency for better-auth is pinned to an exact version 1.4.5 instead of using a version range (e.g., ^1.4.5 or ~1.4.5). This is overly restrictive and will cause installation failures if users have a different patch version of better-auth 1.4.x installed.

Consider using ^1.4.5 to allow compatible patch versions.

Suggested change
"better-auth": "1.4.5",
"better-auth": "^1.4.5",

Copilot uses AI. Check for mistakes.
"convex": "^1.25.0",
"react": "^18.3.1 || ^19.0.0",
"react-dom": "^18.3.1 || ^19.0.0"
},
"devDependencies": {
"@better-fetch/fetch": "^1.1.18",
"@better-fetch/fetch": "^1.1.19",
"@edge-runtime/vm": "5.0.0",
"@eslint/eslintrc": "3.3.1",
"@eslint/eslintrc": "3.3.3",
"@eslint/js": "9.39.1",
"@tanstack/react-start": "^1.132.37",
"@tanstack/react-start": "^1.140.0",
"@types/common-tags": "^1.8.4",
"@types/node": "20.19.24",
"@types/react": "18.3.26",
"@types/react-dom": "18.3.7",
"@types/semver": "^7.7.0",
"@vitejs/plugin-react": "5.0.4",
"concurrently": "^9.2.0",
"@types/node": "24.10.1",
"@types/react": "19.2.7",
"@types/react-dom": "19.2.3",
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @types/react-dom version was updated from 18.3.7 to 19.2.3, which corresponds to React 19. However, the peerDependencies still allow React 18 (react-dom: ^18.3.1 || ^19.0.0). This version mismatch may cause type incompatibility issues for users on React 18.

Consider using @types/react-dom version ^18.3.7 to match the minimum supported React version.

Suggested change
"@types/react-dom": "19.2.3",
"@types/react-dom": "^18.3.7",

Copilot uses AI. Check for mistakes.
Comment on lines +109 to +110
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @types/react version was updated from 18.3.26 to 19.2.7, which corresponds to React 19. However, the peerDependencies still allow React 18 (^18.3.1 || ^19.0.0). Using React 19 types in devDependencies while supporting React 18 in peerDependencies may cause type incompatibility issues for users on React 18.

Consider using @types/react version ^18.3.26 to match the minimum supported React version, or if React 19 is required, update the peerDependencies to reflect that.

Suggested change
"@types/react": "19.2.7",
"@types/react-dom": "19.2.3",
"@types/react": "^18.3.26",
"@types/react-dom": "^18.3.11",

Copilot uses AI. Check for mistakes.
"@types/semver": "^7.7.1",
"@vitejs/plugin-react": "5.1.1",
"concurrently": "^9.2.1",
"chokidar-cli": "3.0.0",
"convex": "^1.29.0",
"convex": "^1.30.0",
"convex-test": "0.0.41",
"cpy-cli": "6.0.0",
"eslint": "9.39.1",
"eslint-plugin-react": "7.37.5",
"eslint-plugin-react-hooks": "5.2.0",
"eslint-plugin-react-hooks": "7.0.1",
"eslint-plugin-react-refresh": "0.4.24",
"globals": "15.14.0",
"next": "^15.1.8",
"npm-run-all2": "7.0.2",
"pkg-pr-new": "0.0.60",
"prettier": "3.6.2",
"react": "18.3.1",
"react-dom": "18.3.1",
"globals": "16.5.0",
"next": "^16.0.7",
"npm-run-all2": "8.0.4",
"pkg-pr-new": "0.0.62",
"prettier": "3.7.4",
"react": "19.2.1",
"react-dom": "19.2.1",
Comment on lines +127 to +128
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The react version was updated from 18.3.1 to 19.2.1 in devDependencies. However, the peerDependencies allow both React 18 and 19 (^18.3.1 || ^19.0.0). While this isn't necessarily wrong, it's better practice to test with the minimum supported version to ensure compatibility.

Consider using React 18.3.1 in devDependencies to test against the minimum supported version, or clearly document that the package is primarily tested with React 19.

Suggested change
"react": "19.2.1",
"react-dom": "19.2.1",
"react": "18.3.1",
"react-dom": "18.3.1",

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The react-dom version was updated from 18.3.1 to 19.2.1 in devDependencies. However, the peerDependencies allow both React 18 and 19 (^18.3.1 || ^19.0.0). While this isn't necessarily wrong, it's better practice to test with the minimum supported version to ensure compatibility.

Consider using React DOM 18.3.1 in devDependencies to test against the minimum supported version.

Suggested change
"react-dom": "19.2.1",
"react-dom": "18.3.1",

Copilot uses AI. Check for mistakes.
"typescript": "5.9.3",
"typescript-eslint": "8.46.4",
"vite": "^7.1.5",
"vitest": "3.2.4"
"typescript-eslint": "8.48.1",
"vite": "^7.2.6",
"vitest": "4.0.15"
},
"types": "./dist/client/index.d.ts",
"module": "./dist/client/index.js",
"dependencies": {
"@better-auth/passkey": "^1.4.5",
"common-tags": "^1.8.2",
"convex-helpers": "^0.1.95",
"jose": "^6.1.0",
"convex-helpers": "^0.1.106",
"jose": "^6.1.3",
"remeda": "^2.32.0",
"semver": "^7.7.3",
"type-fest": "^4.39.1",
"zod": "^3.24.4"
"type-fest": "^5.3.1",
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type-fest version was updated from ^4.39.1 to ^5.3.1, which is a major version bump. Type-fest follows semantic versioning strictly, and major version updates can introduce breaking type changes that may affect the codebase.

Please verify that this major version update doesn't introduce any breaking changes that affect the usage of type-fest in this project.

Copilot uses AI. Check for mistakes.
"zod": "^4.1.13"
}
}
2 changes: 1 addition & 1 deletion src/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
username,
} from "better-auth/plugins";
import { convex } from "./plugins/convex/index.js";
import { passkey } from "better-auth/plugins/passkey";
import { passkey } from "@better-auth/passkey";
import { convexAdapter } from "./client/adapter.js";

// This is the config used to generate the schema
Expand Down