Detect empty env vars #88
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just burned half an hour thanks to this. Boolean coercion is evil. I was setting these options in CI, and due to a misconfiguration one of them was empty string. What was worse, I couldn't repro this locally, because if you have
.env.local
withCONVEX_DEPLOYMENT
, and even if you're not logged in,npx convex deploy --url "" --admin-key ""
does the right thing, but if you don't have.env.local
, then you get erronously:I'd turn on a lint rule that disallows boolean coercion altogether (I don't remember why we didn't do it in the past, maybe it didn't exist?).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.