-
Notifications
You must be signed in to change notification settings - Fork 9
feat: Implement quick review command #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a “Quick Review” command that lets users pick a Git reference as a base and start an AI-driven code review via Navie. Integrates the new action into the plugin configuration, the Navie tool window, and the webview.
- Added Git plugin dependency for Git ref lookup
- Registered and wired up the
appmap.quickReview
action - Exposed a Quick Review button in the Navie tool window and updated webview handling
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
src/main/resources/META-INF/plugin.xml | Added Git4Idea dependency |
plugin-core/src/main/resources/messages/appland.properties | Added property for quick review label |
plugin-core/src/main/resources/META-INF/appmap-core.xml | Registered quick review action in menu |
plugin-core/src/main/java/appland/toolwindow/navie/NaviePanel.java | Added Quick Review button and refactored button creation |
plugin-core/src/main/java/appland/actions/QuickReviewAction.java | Implemented action to fetch Git refs and launch review |
appland-navie/webview.js | Updated subscription logic for initial data |
Comments suppressed due to low confidence (2)
plugin-core/src/main/resources/messages/appland.properties:283
- The label "Review Your Code" differs from the action text "Quick Review". Rename this to "Quick Review" for consistency across the UI.
toolwindow.appmap.navie.quickReview=Review Your Code
plugin-core/src/main/java/appland/actions/QuickReviewAction.java:34
- This new action contains nontrivial Git logic and UI interactions but lacks any unit or integration tests. Consider adding tests for ref fetching, dirty-state filtering, and popup selection callbacks.
public class QuickReviewAction extends AnAction implements DumbAware {
plugin-core/src/main/java/appland/toolwindow/navie/NaviePanel.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugin-core/src/main/java/appland/toolwindow/navie/NaviePanel.java
Outdated
Show resolved
Hide resolved
plugin-core/src/main/java/appland/actions/QuickReviewAction.java
Outdated
Show resolved
Hide resolved
plugin-core/src/main/java/appland/actions/QuickReviewAction.java
Outdated
Show resolved
Hide resolved
plugin-core/src/main/java/appland/actions/QuickReviewAction.java
Outdated
Show resolved
Hide resolved
plugin-core/src/main/java/appland/actions/QuickReviewAction.java
Outdated
Show resolved
Hide resolved
plugin-core/src/main/java/appland/actions/QuickReviewAction.java
Outdated
Show resolved
Hide resolved
Adds a new command `appmap.quickReview` that allows users to select a Git reference (branch, tag, or commit) as a base and initiate an AI-driven code review of the changes relative to that base via Navie. Integrates the command into the Navie tool window and the menu.
57b55e3
to
eff9e48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks better now. Thank you!
I tested it, but I couldn't make Navie do anything. After choosing a commit from popup of Git items, a new Navie window is opened but it just sits there without doing anything.
Is the suggestion
property correct?
This JSON was sent to Navie:
{
"type": "init",
"appmapRpcPort": 36023,
"apiKey": "Z2l0aHViQGphLWRldi5ldTpmNzVlMTA0Ni0yNjc2LTRmNWYtYTBjYy1kOTA2MzQxZGQxODE",
"appmapYmlPresent": false,
"savedFilters": [
{
"filterName": "AppMap default",
"state": "eyJmaWx0ZXJzIjp7fX0",
"default": false
}
],
"mostRecentAppMaps": [],
"suggestion": {
"label": "Quick Review",
"prompt": "@review /base=7034d17"
},
"useAnimation": true,
"preselectedModelId": "Copilot:claude-3.5-sonnet"
}
plugin-core/src/main/java/appland/actions/QuickReviewAction.java
Outdated
Show resolved
Hide resolved
plugin-core/src/main/java/appland/actions/QuickReviewAction.java
Outdated
Show resolved
Hide resolved
Yes, it's correct. Sometimes it seems to sit for a while and do nothing but it's actually working in the background — that's a different bug, I suppose. Could you give it another try with this in mind? |
I tried this again and this time a response was shown, i.e. it appears to be working as expected. |
@dividedmind Please let me know when you need a new review. |
Adds a new command
appmap.quickReview
that allows users to select a Git reference (branch, tag, or commit) as a base and initiate an AI-driven code review of the changes relative to that base via Navie. Integrates the command into the Navie tool window and the menu.Note this is a port of getappmap/vscode-appland#1094