Better error handling for webview-based editors #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansorg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of errors loading a webview editor.
After the message is confirmed by the user, the editor is closed because it's not fully initialized.
Instead of returning null or just logging errors, exceptions are now handled more granular and shown to the user.
To test the timeout, you could change this timeout to 10 seconds: https://github.com/applandinc/appmap-intellij-plugin/blob/444ffce3b9b094ae98db565ec7cf6e1ac89e5fbc/plugin-core/src/main/java/appland/files/AppMapFiles.java#L57
Error message after timeout of the stats command:
