Skip to content

feat: Present activate with email errors to the user #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Present activate with email errors to the user #1847

wants to merge 1 commit into from

Conversation

zermelo-wisen
Copy link
Contributor

Fixes #1843.

  • Presents the error directly to the user for all non-201 response codes coming from server.
  • Limits the error text maximum height in order not to obscure the form.
  • Adds a test to ensure that error messages for status codes 422 and 500 are shown directly in the UI and removes the old tests for 422 and 500.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustinbyrne dustinbyrne Awaiting requested review from dustinbyrne

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Activate with email errors are presented to the user
1 participant
@zermelo-wisen