fix (cli): Parse indented code blocks #2286
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the frontend to receive metadata about the codeblock instead of relying on default markdown styling
|
Without the associated front end fix, indented code blocks will render like so: |
|
With the frontend fix: |
|
@dividedmind this is coded and has tests. Should it be merged? |
I dunno, looks ok to me, but it's still marked as draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two fixes:
Thread.onTokento correctly identify code fences (```) and file comments (<!-- file: -->) even when they are indented (e.g., within lists). This ensures the frontend receives proper metadata for syntax highlighting and other features. Resolves Code block parsing does not expect whitespace before code fences #2281dall-eand others containingimage) from the list fetched from OpenAI, as they are not relevant for Navie's text-based interactions. Also refactors the exclusion logic slightly for clarity.