Rework the summary view to use the new widget answer components #7009
+380
−249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
force-pushed
the
new_summary_view
branch
2 times, most recently
from
e4a0d35 to
f57d393
Compare
grzesiek2010
force-pushed
the
new_summary_view
branch
from
f57d393 to
f7a0b7a
Compare
grzesiek2010
force-pushed
the
new_summary_view
branch
2 times, most recently
from
80c4738 to
9266b68
Compare
grzesiek2010
force-pushed
the
new_summary_view
branch
from
9266b68 to
56903bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards ##6084
Why is this the best possible solution? Were any other approaches considered?
There’s nothing critical to discuss here. This change simply reworks the summary view to use shared components, which was the core of the feature.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This update reworks how answers (only answers, not regular groups, repeatable groups, or question labels) are displayed in the summary view, leveraging the recently added components from:
With this change, new components, such as the video component, should now appear in the summary view, alongside answers with icons (e.g., barcode, file).
Please test to ensure everything works correctly in this context. Additionally, verify styled answers using the guidelines here: https://docs.getodk.org/form-styling/.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest