Fixed using raw strings as requiredMsg #731
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
requested changes
Dec 5, 2023
|
|
||
| public String getRequiredText() { | ||
| // look for the text under the requiredMsg bind attribute | ||
| String constraintText = form.getMainInstance().resolveReference(index.getReference()).getBindAttributeValue(XFormParser.NAMESPACE_JAVAROSA, |
Member
There was a problem hiding this comment.
This should be requiredMsgText or something, right? It has nothing to do with constraints?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #730
What has been done to verify that this works as intended?
I've tested the changes manually with ODK Collect and also added automated tests.
Why is this the best possible solution? Were any other approaches considered?
Nothing to discuss here.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
We can focus on testing custom retired messages. The fix is rather safe and isolated so I can't think of any risk in any other area of the project. However we should start testing once we implement changes in Collect and start using the new method for reading required messages.
Do we need any specific form for testing your changes? If so, please attach one.
I used the one attached in the issue.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.