Improve tests based on findings from porting them to Web Forms #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
changed the title
| input("label")), | ||
| input("/data/repeat/value"), | ||
| input("/data/repeat/label")), | ||
| input("filter"), |
There was a problem hiding this comment.
Looks like this one was missed (though another for the same name was caught below). I suspect there may be more. I'll try to catalogue them all so they can be updated together.
It's also unclear to me whether itemsets should be addressed the same way. E.g. should "../repeat" in the select1Dynamic call on the next line be /data/repeat? That might make sense here, but I'm less sure about extending that reasoning to relative itemset nodesets from within repeats.
lognaturel
force-pushed
the
standard-tests
branch
from
c72b80b to
015a677
Compare
These relative refs were likely introduced by analogy to itemset declarations
lognaturel
force-pushed
the
standard-tests
branch
from
015a677 to
6ece043
Compare
lognaturel
changed the title
lognaturel
referenced
this pull request
in getodk/web-forms
May 24, 2024
…output Includes two alternates: 1. Adapt direct port to use proposed `Scenario` API 2. Fix apparent mistakes in test: it doesn’t exercise `jr:itext`, correctly close the itext id attribute Adds proposed `labelRef` to form fixture DSL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress as we discover more of these
TODO:
newInstancegetodk/web-forms@90eb940#diff-d16f69d83353a76da661b703e67eb17e129b62d24fea77849e62551c26534136R1054Beforegetodk/web-forms@25b6387#diff-ba0f0f0dd232b5db2c99a21841beb634f81aa48b6976b31afdd39e4a24375557R11indexOffrom scenariogetAnswerNodetogetInstanceNodeCloses #
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
Does this change require updates to documentation? If so, please file an issue here and include the link below.