chore: fixes scenario test #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lognaturel
approved these changes
Jan 5, 2026
Member
lognaturel
left a comment
lognaturel
left a comment
There was a problem hiding this comment.
I probably would have looked at setting the date in the test fixture but I'm happy to go along with the easy change for now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
What's changed
Update birth year options in
child_vaccination_VOL_tool_v12-alt.xmlto support current test dates.Previously, the
<select1>for/data/household/child_repeat/dob_yearonly included outdated options (2017-2019), which prevented valid selections for dynamic DOB calculations (e.g., 2024 for a 23-month-old child in 2026). This caused mismatches in leap year logic and test failures in January when DOBs land in February of a leap year.Updated options to 2024, 2025, and 2026 to align with children under 2 years old, as a practical quick fix. Tests now pass consistently. No changes to test code or data.
Note: This will need revisiting in January 2030, but it's sufficient for now.
See error in CI