feat(processor): Add Span Attachment scrubbing logic #5449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-wilfert
commented
Dec 5, 2025
tobias-wilfert
commented
Dec 9, 2025
| let ExpandedAttachment { meta, body } = attachment; | ||
|
|
||
| relay_pii::eap::scrub( | ||
| ValueType::Attachments, // TODO: How do we event want to allow people to filter here? |
Member
Author
There was a problem hiding this comment.
Not sure if Span or Attachment makes more sense here for the user.
jjbayer
approved these changes
Dec 9, 2025
|
|
||
| let processor = PiiAttachmentsProcessor::new(config.compiled()); | ||
| let mut payload = body.to_vec(); | ||
| if processor.scrub_attachment(filename, &mut payload) { |
Member
There was a problem hiding this comment.
I think we should emit the timer(RelayTimers::AttachmentScrubbing) metric here, either directly or by calling processing::utils::attachments::scrub_attachment.
loewenheim
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the logic to scrub the attachment body as well as the attachment meta.