ref(instr): Lower logging level for replay errors #5455
+7
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
Dec 9, 2025
Dav1dde
force-pushed
the
dav1d/rm-replay-logs
branch
from
6f33d47 to
50b9dce
Compare
billyvg
reviewed
Dec 9, 2025
| match &error { | ||
| relay_replays::recording::ParseRecordingError::Compression(e) => { | ||
| // 20k errors per day at 0.1% sample rate == 20 logs per day | ||
| if sample(0.001).is_keep() { |
Member
There was a problem hiding this comment.
Is it ok to get rid of this sampling?
| event_id = ?config.event_id, | ||
| project_id = config.project_id.map(|v| v.value()), | ||
| organization_id = config.organization_id.map(|o| o.value()), | ||
| "ParseRecordingError::Message" |
Member
There was a problem hiding this comment.
Can we keep the two different types? (message vs compression)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reached out to the Replays team if these errors still have value for them.