-
-
Couldn't load subscription status.
- Fork 369
feat(V9): Remove SentryRedactviewHelper from API #5860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
59bc817 to
fc6362d
Compare
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9e0030e | 1222.78 ms | 1242.23 ms | 19.45 ms |
| b57ee62 | 1218.21 ms | 1248.94 ms | 30.73 ms |
| 605fa27 | 1226.31 ms | 1251.35 ms | 25.05 ms |
| 8d944ac | 1236.92 ms | 1254.91 ms | 18.00 ms |
| 1fe932f | 1231.92 ms | 1253.44 ms | 21.52 ms |
| 65ebbdb | 1233.96 ms | 1255.79 ms | 21.83 ms |
| 43597ba | 1214.88 ms | 1243.52 ms | 28.65 ms |
| cc7f629 | 1226.00 ms | 1245.51 ms | 19.51 ms |
| 65f8d2e | 1221.15 ms | 1243.96 ms | 22.81 ms |
| 2691350 | 1224.92 ms | 1255.82 ms | 30.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9e0030e | 23.75 KiB | 893.72 KiB | 869.97 KiB |
| b57ee62 | 23.75 KiB | 912.47 KiB | 888.72 KiB |
| 605fa27 | 23.75 KiB | 908.03 KiB | 884.28 KiB |
| 8d944ac | 23.75 KiB | 919.69 KiB | 895.94 KiB |
| 1fe932f | 23.75 KiB | 913.63 KiB | 889.88 KiB |
| 65ebbdb | 23.75 KiB | 902.33 KiB | 878.59 KiB |
| 43597ba | 23.75 KiB | 880.32 KiB | 856.58 KiB |
| cc7f629 | 23.75 KiB | 878.48 KiB | 854.73 KiB |
| 65f8d2e | 23.74 KiB | 872.67 KiB | 848.93 KiB |
| 2691350 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
Previous results on branch: removeRedactViewAPI
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0ac7d55 | 1216.71 ms | 1235.31 ms | 18.60 ms |
| e49f340 | 1226.61 ms | 1255.63 ms | 29.02 ms |
| efca979 | 1235.53 ms | 1266.22 ms | 30.69 ms |
| 6ae658b | 1231.91 ms | 1251.63 ms | 19.72 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0ac7d55 | 23.75 KiB | 926.64 KiB | 902.89 KiB |
| e49f340 | 23.75 KiB | 913.71 KiB | 889.97 KiB |
| efca979 | 23.75 KiB | 920.82 KiB | 897.07 KiB |
| 6ae658b | 23.75 KiB | 913.70 KiB | 889.95 KiB |
fc6362d to
7ad0d33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I double-checked an you are correct, but I did find this PR comment about changing it to be public:
https://github.com/getsentry/sentry-cocoa/pull/4392/files#r1784344132
|
Maybe we should also add a changelog entry just in case. |
56324a9 to
5c5a96a
Compare
|
@noahsmartin what keeps you from merging this PR? |
|
It's currently failing CI so going to convert back to draft |
This must have accidentally been made public, let's fix that in V9
#skip-changelog