Skip to content

Conversation

philprime
Copy link
Member

📜 Description

Adds the AVPlayerView used by AVKit.AVPlayerViewController to the list of default classes to be masked in session replay.

💡 Motivation and Context

See the internal issue

💚 How did you test it?

This PR adds an sample video player using the AVKit.AVPlayerViewController to

simulator_screenshot_23C2F322-E173-41F1-ACD9-6D7821BB30ED

Replay without masking (before this PR):

https://sentry-sdks.sentry.io/explore/replays/6d3ebdbc1c5248bc9315415663846bf1/?project=5428557&query=&referrer=%2Fexplore%2Freplays%2F%3AreplaySlug%2F&statsPeriod=1h&yAxis=count%28%29&t=14

Replay with masking (after this PR):

https://sentry-sdks.sentry.io/explore/replays/fd405624231f4f89957eb2ab3c12dd4c/?project=4509348709924865&project=5428557&query=&referrer=%2Fexplore%2Freplays%2F%3AreplaySlug%2F&statsPeriod=1h&yAxis=count%28%29&t=13

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@philprime philprime self-assigned this Aug 13, 2025
@philprime philprime marked this pull request as ready for review August 13, 2025 14:18
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.719%. Comparing base (0ede342) to head (73ff114).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5910       +/-   ##
=============================================
- Coverage   86.720%   86.719%   -0.002%     
=============================================
  Files          424       424               
  Lines        36712     36715        +3     
  Branches     17362     17358        -4     
=============================================
+ Hits         31837     31839        +2     
+ Misses        4831      4829        -2     
- Partials        44        47        +3     
Files with missing lines Coverage Δ
...Core/Tools/ViewCapture/SentryUIRedactBuilder.swift 94.420% <100.000%> (+0.072%) ⬆️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ede342...73ff114. Read the comment docs.

Copy link
Contributor

github-actions bot commented Aug 13, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1208.70 ms 1231.63 ms 22.92 ms
Size 23.75 KiB 928.13 KiB 904.39 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
748df9d 1231.63 ms 1259.47 ms 27.84 ms
9e6569a 1216.07 ms 1242.50 ms 26.43 ms
45482a6 1225.88 ms 1254.27 ms 28.39 ms
aa0b738 1236.78 ms 1253.08 ms 16.31 ms
a3dfd57 1230.78 ms 1244.91 ms 14.14 ms
1936411 1231.51 ms 1253.27 ms 21.76 ms
ccf1278 1226.84 ms 1248.51 ms 21.67 ms
884b224 1221.11 ms 1255.88 ms 34.77 ms
605fa27 1226.31 ms 1251.35 ms 25.05 ms
a2a3bfb 1227.94 ms 1261.26 ms 33.32 ms

App size

Revision Plain With Sentry Diff
748df9d 23.75 KiB 902.48 KiB 878.74 KiB
9e6569a 23.75 KiB 904.54 KiB 880.79 KiB
45482a6 23.75 KiB 919.91 KiB 896.16 KiB
aa0b738 23.74 KiB 872.75 KiB 849.00 KiB
a3dfd57 23.75 KiB 913.63 KiB 889.87 KiB
1936411 23.74 KiB 913.39 KiB 889.64 KiB
ccf1278 23.75 KiB 877.15 KiB 853.40 KiB
884b224 23.75 KiB 879.55 KiB 855.80 KiB
605fa27 23.75 KiB 908.03 KiB 884.28 KiB
a2a3bfb 23.75 KiB 872.67 KiB 848.92 KiB

Previous results on branch: philprime/sr-video-view-masking

Startup times

Revision Plain With Sentry Diff
a16bfdc 1229.71 ms 1240.00 ms 10.29 ms
12fc9fd 1225.38 ms 1250.16 ms 24.78 ms
8de6a44 1222.20 ms 1245.94 ms 23.74 ms
3f9e14e 1227.50 ms 1252.10 ms 24.60 ms
5c62005 1226.09 ms 1257.98 ms 31.89 ms
6f9120b 1216.86 ms 1237.28 ms 20.42 ms
80c772c 1220.45 ms 1238.46 ms 18.01 ms

App size

Revision Plain With Sentry Diff
a16bfdc 23.75 KiB 920.92 KiB 897.17 KiB
12fc9fd 23.75 KiB 928.20 KiB 904.45 KiB
8de6a44 23.75 KiB 926.73 KiB 902.98 KiB
3f9e14e 23.74 KiB 926.65 KiB 902.91 KiB
5c62005 23.75 KiB 926.72 KiB 902.97 KiB
6f9120b 23.74 KiB 926.65 KiB 902.91 KiB
80c772c 23.75 KiB 920.84 KiB 897.09 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, when CI is green.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@philprime philprime added the Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks. label Aug 27, 2025
@philprime philprime enabled auto-merge (squash) August 28, 2025 09:06
@philprime philprime merged commit d66f082 into main Aug 29, 2025
165 of 168 checks passed
@philprime philprime deleted the philprime/sr-video-view-masking branch August 29, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants