Skip to content

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Aug 13, 2025

Uses a script to select which variants we want to build on the release workflow.

Fixes: #5940

Note: The script is still in draft because it can possible be improved and moved to scripts

Copy link
Contributor

github-actions bot commented Aug 13, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.94 ms 1241.20 ms 19.27 ms
Size 23.75 KiB 928.15 KiB 904.41 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
30f4e4c 1213.21 ms 1250.29 ms 37.08 ms
7c7ac56 1225.90 ms 1250.22 ms 24.33 ms
b57ee62 1218.21 ms 1248.94 ms 30.73 ms
be6a4ee 1226.33 ms 1249.77 ms 23.44 ms
0ede342 1233.47 ms 1262.29 ms 28.82 ms
e0424b9 1204.23 ms 1241.08 ms 36.85 ms
27e7514 1229.47 ms 1245.60 ms 16.13 ms
6279992 1213.60 ms 1241.38 ms 27.79 ms
130c6ba 1237.02 ms 1259.67 ms 22.65 ms
ea5a59b 1222.87 ms 1253.47 ms 30.60 ms

App size

Revision Plain With Sentry Diff
30f4e4c 23.75 KiB 879.24 KiB 855.50 KiB
7c7ac56 23.75 KiB 902.49 KiB 878.74 KiB
b57ee62 23.75 KiB 912.47 KiB 888.72 KiB
be6a4ee 23.75 KiB 913.14 KiB 889.39 KiB
0ede342 23.75 KiB 928.15 KiB 904.40 KiB
e0424b9 23.74 KiB 874.07 KiB 850.33 KiB
27e7514 23.75 KiB 919.69 KiB 895.94 KiB
6279992 23.75 KiB 891.03 KiB 867.28 KiB
130c6ba 23.75 KiB 926.65 KiB 902.89 KiB
ea5a59b 23.75 KiB 874.46 KiB 850.71 KiB

Previous results on branch: itaybre/build_only_selected_variants_on_each_pr

Startup times

Revision Plain With Sentry Diff
54085ca 1233.89 ms 1259.19 ms 25.30 ms
72312e4 1214.62 ms 1237.91 ms 23.29 ms
f2099ac 1241.71 ms 1264.00 ms 22.29 ms
31e3872 1234.00 ms 1259.06 ms 25.06 ms
3200dab 1214.27 ms 1247.09 ms 32.82 ms

App size

Revision Plain With Sentry Diff
54085ca 23.74 KiB 926.64 KiB 902.90 KiB
72312e4 23.75 KiB 928.15 KiB 904.40 KiB
f2099ac 23.75 KiB 919.90 KiB 896.15 KiB
31e3872 23.75 KiB 926.64 KiB 902.90 KiB
3200dab 23.75 KiB 920.64 KiB 896.89 KiB

@itaybre itaybre marked this pull request as ready for review August 14, 2025 13:58
cursor[bot]

This comment was marked as outdated.

@itaybre itaybre mentioned this pull request Aug 14, 2025
@itaybre itaybre force-pushed the itaybre/build_only_selected_variants_on_each_pr branch from 3e968bb to 8fb9223 Compare August 15, 2025 14:11
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but left a comment for potential improvement in maintainability

Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.742%. Comparing base (3cdbc22) to head (43c0584).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5941       +/-   ##
=============================================
+ Coverage   86.704%   86.742%   +0.038%     
=============================================
  Files          424       424               
  Lines        36712     36712               
  Branches     17360     17361        +1     
=============================================
+ Hits         31831     31845       +14     
- Misses        4598      4823      +225     
+ Partials       283        44      -239     

see 40 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cdbc22...43c0584. Read the comment docs.

@itaybre itaybre enabled auto-merge (squash) August 28, 2025 14:49
@itaybre itaybre merged commit c03a8d8 into main Aug 28, 2025
120 of 123 checks passed
@itaybre itaybre deleted the itaybre/build_only_selected_variants_on_each_pr branch August 28, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce the number of runners used per PR
3 participants