-
-
Notifications
You must be signed in to change notification settings - Fork 363
ref: Convert SentryMeasurementValue to Swift #5981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
687136c
to
c2cf415
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5981 +/- ##
========================================
Coverage ? 86.706%
========================================
Files ? 424
Lines ? 36711
Branches ? 17355
========================================
Hits ? 31831
Misses ? 4834
Partials ? 46
Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
cc7f629 | 1226.00 ms | 1245.51 ms | 19.51 ms |
80a5166 | 1224.49 ms | 1251.29 ms | 26.80 ms |
82f60cf | 1218.65 ms | 1238.52 ms | 19.87 ms |
b9aacb6 | 1230.42 ms | 1251.00 ms | 20.58 ms |
2691350 | 1224.92 ms | 1255.82 ms | 30.90 ms |
9080e6c | 1221.17 ms | 1247.87 ms | 26.71 ms |
326984b | 1235.06 ms | 1252.75 ms | 17.69 ms |
2a36c3f | 1227.27 ms | 1246.89 ms | 19.63 ms |
916edbe | 1243.86 ms | 1256.11 ms | 12.25 ms |
324c109 | 1228.35 ms | 1252.47 ms | 24.12 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
cc7f629 | 23.75 KiB | 878.48 KiB | 854.73 KiB |
80a5166 | 23.75 KiB | 904.53 KiB | 880.78 KiB |
82f60cf | 23.75 KiB | 913.63 KiB | 889.88 KiB |
b9aacb6 | 23.75 KiB | 913.64 KiB | 889.89 KiB |
2691350 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
9080e6c | 23.75 KiB | 926.80 KiB | 903.05 KiB |
326984b | 23.74 KiB | 926.64 KiB | 902.90 KiB |
2a36c3f | 23.75 KiB | 874.45 KiB | 850.71 KiB |
916edbe | 23.75 KiB | 908.41 KiB | 884.66 KiB |
324c109 | 23.75 KiB | 919.91 KiB | 896.16 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but CI is not happy yet:
Error: type of expression is ambiguous without more context
XCTAssertEqual(tracer.measurements[name]?.value, NSNumber(value: duration))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: 'unit' is inaccessible due to '@_spi' protection level
XCTAssertEqual(tracer.measurements[name]?.unit?.unit, "millisecond")
#skip-changelog