Skip to content

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Aug 16, 2025

#skip-changelog

@noahsmartin noahsmartin force-pushed the convertSentryMeasurementValueSwift branch from 687136c to c2cf415 Compare August 22, 2025 23:14
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@af7a86c). Learn more about missing BASE report.
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #5981   +/-   ##
========================================
  Coverage        ?   86.706%           
========================================
  Files           ?       424           
  Lines           ?     36711           
  Branches        ?     17355           
========================================
  Hits            ?     31831           
  Misses          ?      4834           
  Partials        ?        46           
Files with missing lines Coverage Δ
Sources/Sentry/SentrySpan.m 97.701% <ø> (ø)
Sources/Sentry/SentryTimeToDisplayTracker.m 100.000% <ø> (ø)
Sources/Sentry/SentryTracer.m 97.704% <ø> (ø)
Sources/Sentry/SentryTransaction.m 91.566% <ø> (ø)
...ces/Swift/Transaction/SentryMeasurementValue.swift 100.000% <100.000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af7a86c...41dab02. Read the comment docs.

Copy link
Contributor

github-actions bot commented Aug 22, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.10 ms 1255.85 ms 28.75 ms
Size 23.75 KiB 927.42 KiB 903.67 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
cc7f629 1226.00 ms 1245.51 ms 19.51 ms
80a5166 1224.49 ms 1251.29 ms 26.80 ms
82f60cf 1218.65 ms 1238.52 ms 19.87 ms
b9aacb6 1230.42 ms 1251.00 ms 20.58 ms
2691350 1224.92 ms 1255.82 ms 30.90 ms
9080e6c 1221.17 ms 1247.87 ms 26.71 ms
326984b 1235.06 ms 1252.75 ms 17.69 ms
2a36c3f 1227.27 ms 1246.89 ms 19.63 ms
916edbe 1243.86 ms 1256.11 ms 12.25 ms
324c109 1228.35 ms 1252.47 ms 24.12 ms

App size

Revision Plain With Sentry Diff
cc7f629 23.75 KiB 878.48 KiB 854.73 KiB
80a5166 23.75 KiB 904.53 KiB 880.78 KiB
82f60cf 23.75 KiB 913.63 KiB 889.88 KiB
b9aacb6 23.75 KiB 913.64 KiB 889.89 KiB
2691350 23.75 KiB 850.73 KiB 826.98 KiB
9080e6c 23.75 KiB 926.80 KiB 903.05 KiB
326984b 23.74 KiB 926.64 KiB 902.90 KiB
2a36c3f 23.75 KiB 874.45 KiB 850.71 KiB
916edbe 23.75 KiB 908.41 KiB 884.66 KiB
324c109 23.75 KiB 919.91 KiB 896.16 KiB

Previous results on branch: convertSentryMeasurementValueSwift

Startup times

Revision Plain With Sentry Diff
609bd9a 1220.35 ms 1243.45 ms 23.09 ms

App size

Revision Plain With Sentry Diff
609bd9a 23.74 KiB 927.21 KiB 903.46 KiB

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but CI is not happy yet:

Error: type of expression is ambiguous without more context
        XCTAssertEqual(tracer.measurements[name]?.value, NSNumber(value: duration))
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: 'unit' is inaccessible due to '@_spi' protection level
        XCTAssertEqual(tracer.measurements[name]?.unit?.unit, "millisecond")

@noahsmartin noahsmartin merged commit ae79d35 into main Aug 27, 2025
208 of 212 checks passed
@noahsmartin noahsmartin deleted the convertSentryMeasurementValueSwift branch August 27, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants