Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions Sentry.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion SentryTestUtils/SentryTestUtils-ObjC-BridgingHeader.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@

#import "PrivateSentrySDKOnly.h"
#import "SentryAppStartMeasurement.h"
#import "SentryBinaryImageCache.h"
#import "SentryClient+Private.h"
#import "SentryClient+TestInit.h"
#import "SentryCrash+Test.h"
Expand Down
1 change: 0 additions & 1 deletion Sources/Resources/Sentry.modulemap
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ framework module Sentry {
header "PrivateSentrySDKOnly.h"
header "PrivatesHeader.h"
header "SentryAppStartMeasurement.h"
header "SentryBinaryImageCache.h"
header "SentryBreadcrumb+Private.h"
header "SentryDebugImageProvider+HybridSDKs.h"
header "SentryDependencyContainer.h"
Expand Down
197 changes: 0 additions & 197 deletions Sources/Sentry/SentryBinaryImageCache.m

This file was deleted.

3 changes: 1 addition & 2 deletions Sources/Sentry/SentryCrashStackEntryMapper.m
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#import "SentryCrashStackEntryMapper.h"
#import "SentryBinaryImageCache.h"
#import "SentryDependencyContainer.h"
#import "SentryFormatter.h"
#import "SentryFrame.h"
Expand Down Expand Up @@ -42,7 +41,7 @@ - (SentryFrame *)sentryCrashStackEntryToSentryFrame:(SentryCrashStackEntry)stack
// we get image from the cache.
if (stackEntry.imageAddress == 0 && stackEntry.imageName == NULL) {
SentryBinaryImageInfo *info = [SentryDependencyContainer.sharedInstance.binaryImageCache
imageByAddress:stackEntry.address];
imageByAddress:(uint64_t)stackEntry.address];

frame.imageAddress = sentry_formatHexAddressUInt64(info.address);
frame.package = info.name;
Expand Down
4 changes: 2 additions & 2 deletions Sources/Sentry/SentryDebugImageProvider.m
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#import "SentryDebugImageProvider.h"
#import "SentryBinaryImageCache.h"
#import "SentryDebugImageProvider+HybridSDKs.h"
#if !SDK_V9
# import "SentryCrashDefaultBinaryImageProvider.h"
Expand All @@ -13,6 +12,7 @@
#import "SentryInternalDefines.h"
#import "SentryLogC.h"
#import "SentryStacktrace.h"
#import "SentrySwift.h"
#import "SentryThread.h"
#import <Foundation/Foundation.h>

Expand Down Expand Up @@ -228,7 +228,7 @@ - (SentryDebugMeta *)fillDebugMetaFrom:(SentryCrashBinaryImage)image
- (SentryDebugMeta *)fillDebugMetaFromBinaryImageInfo:(SentryBinaryImageInfo *)info
{
SentryDebugMeta *debugMeta = [[SentryDebugMeta alloc] init];
debugMeta.debugID = info.UUID;
debugMeta.debugID = info.uuid;
debugMeta.type = SentryDebugImageType;

if (info.vmAddress > 0) {
Expand Down
1 change: 0 additions & 1 deletion Sources/Sentry/SentryDependencyContainer.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#import "SentryANRTrackerV1.h"

#import "SentryApplication.h"
#import "SentryBinaryImageCache.h"
#import "SentryDefaultObjCRuntimeWrapper.h"
#import "SentryDispatchFactory.h"
#import "SentryDisplayLinkWrapper.h"
Expand Down
1 change: 0 additions & 1 deletion Sources/Sentry/SentrySDKInternal.m
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
#import "SentryANRTrackingIntegration.h"
#import "SentryAppStartMeasurement.h"
#import "SentryAppStateManager.h"
#import "SentryBinaryImageCache.h"
#import "SentryBreadcrumb.h"
#import "SentryClient+Private.h"
#import "SentryCrash.h"
Expand Down
1 change: 0 additions & 1 deletion Sources/Sentry/SentryUIViewControllerSwizzling.m
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

#if SENTRY_HAS_UIKIT

# import "SentryBinaryImageCache.h"
# import "SentryDefaultObjCRuntimeWrapper.h"
# import "SentryDefines.h"
# import "SentryDependencyContainer.h"
Expand Down
35 changes: 0 additions & 35 deletions Sources/Sentry/include/HybridPublic/SentryBinaryImageCache.h

This file was deleted.

14 changes: 14 additions & 0 deletions Sources/Sentry/include/SentryBinaryImageCacheCallbacks.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#import "SentryCrashDynamicLinker.h"
#import <Foundation/Foundation.h>

#ifdef __cplusplus
extern "C" {
#endif

void binaryImageWasAdded(const SentryCrashBinaryImage *_Nullable image);

void binaryImageWasRemoved(const SentryCrashBinaryImage *_Nullable image);

#ifdef __cplusplus
}
#endif
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
#include "SentryCrashDynamicLinker.h"
#include <stdio.h>

#ifdef __cplusplus
extern "C" {
#endif

typedef void (*sentrycrashbic_imageIteratorCallback)(SentryCrashBinaryImage *, void *context);

typedef void (*sentrycrashbic_cacheChangeCallback)(const SentryCrashBinaryImage *binaryImage);
Expand Down Expand Up @@ -33,4 +37,8 @@ void sentrycrashbic_registerAddedCallback(sentrycrashbic_cacheChangeCallback cal
*/
void sentrycrashbic_registerRemovedCallback(sentrycrashbic_cacheChangeCallback callback);

#ifdef __cplusplus
}
#endif

#endif /* SentryCrashBinaryImageCache_h */
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@
#ifndef HDR_SentryCrashDynamicLinker_h
#define HDR_SentryCrashDynamicLinker_h

#ifdef __cplusplus
extern "C" {
#endif

#include <dlfcn.h>
#include <stdbool.h>
#include <stdint.h>

#ifdef __cplusplus
extern "C" {
#endif

#define SENTRY_DYLD_INDEX UINT_MAX - 1

#if __LP64__
Expand Down
4 changes: 4 additions & 0 deletions Sources/Sentry/include/SentryPrivate.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
// Sentry internal headers that are needed for swift code; you cannot import headers that depend on
// public interfaces here
#import "NSLocale+Sentry.h"
#import "SentryBinaryImageCacheCallbacks.h"
#import "SentryCrashBinaryImageCache.h"
#import "SentryCrashDynamicLinker.h"
#import "SentryCrashExceptionApplicationHelper.h"
#import "SentryCrashUUIDConversion.h"
#import "SentryEventSwiftHelper.h"
#import "SentryNSDataUtils.h"
#import "SentryObjCRuntimeWrapper.h"
Expand Down
Loading
Loading