Skip to content

Conversation

philprime
Copy link
Member

📜 Description

Migrates the lint-swiftlint-formatting workflow to use dorny/paths-filter for conditional execution on pull requests. This involves:

  • Removing on.pull_request.paths filtering from the workflow.
  • Adding a files-changed job to detect relevant changes using a new filter run_lint_swiftlint_formatting_for_prs in .github/file-filters.yml.
  • Making the main lint job conditional based on the files-changed job's output.
  • Introducing a lint_swiftlint_formatting-required-check job to serve as a consistent required check for branch protection rules.

💡 Motivation and Context

This change is part of the ongoing effort (see #5951 and #5893) to replace on.[event].paths filtering with dorny/paths-filter across all workflows. The primary motivation is to enable more efficient conditional execution of CI jobs on pull requests while providing a reliable, always-running "required check" for branch protection rules. This ensures that the SwiftLint formatting check only runs when relevant files are modified, but its overall status (passed or skipped) is always reported.

Fixes #5963

💚 How did you test it?

The changes are to the CI pipeline itself and will be validated by the CI run of this pull request.

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

#skip-changelog

@philprime philprime self-assigned this Aug 27, 2025
Copy link

codecov bot commented Aug 27, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
32133 1 32132 97
View the full list of 1 ❄️ flaky tests
SentryTests.SentryANRTrackerV1Tests::testMultipleListeners

Flake rate in main: 7.41% (Passed 25 times, Failed 2 times)

Stack Traces | 0s run time
.../Integrations/ANR/SentryANRTrackerV1Tests.swift:78 - Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "ANR Detection".

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@philprime philprime marked this pull request as ready for review August 27, 2025 17:50
@philprime
Copy link
Member Author

Duplicate of #6006

@philprime philprime marked this as a duplicate of #6006 Aug 28, 2025
@philprime philprime closed this Aug 28, 2025
@philprime philprime deleted the cursor/implement-conditional-lint-swiftlint-formatting-8ceb branch August 28, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(ci): Add required checks job for lint swiftlint formatting
3 participants