-
-
Notifications
You must be signed in to change notification settings - Fork 363
chore(ci): Add required checks job for lint dprint #6002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Add required checks job for lint dprint #6002
Conversation
Co-authored-by: phil.niedertscheider <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6002 +/- ##
=============================================
- Coverage 86.734% 86.712% -0.022%
=============================================
Files 424 424
Lines 36712 36712
Branches 17360 17359 -1
=============================================
- Hits 31842 31834 -8
- Misses 4823 4831 +8
Partials 47 47 see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…ired-checks-for-lint-dprint-c1d3
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d0f70ce | 1226.54 ms | 1247.04 ms | 20.50 ms |
6279992 | 1213.60 ms | 1241.38 ms | 27.79 ms |
73c9712 | 1238.57 ms | 1260.38 ms | 21.80 ms |
d05d866 | 1211.78 ms | 1230.96 ms | 19.18 ms |
605fa27 | 1226.31 ms | 1251.35 ms | 25.05 ms |
cc7f629 | 1226.00 ms | 1245.51 ms | 19.51 ms |
b41e6a7 | 1201.65 ms | 1246.12 ms | 44.47 ms |
d83b35a | 1212.48 ms | 1237.02 ms | 24.54 ms |
61414e8 | 1225.49 ms | 1254.28 ms | 28.79 ms |
7c7ac56 | 1225.90 ms | 1250.22 ms | 24.33 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d0f70ce | 23.75 KiB | 913.09 KiB | 889.34 KiB |
6279992 | 23.75 KiB | 891.03 KiB | 867.28 KiB |
73c9712 | 23.75 KiB | 908.01 KiB | 884.26 KiB |
d05d866 | 23.75 KiB | 878.60 KiB | 854.85 KiB |
605fa27 | 23.75 KiB | 908.03 KiB | 884.28 KiB |
cc7f629 | 23.75 KiB | 878.48 KiB | 854.73 KiB |
b41e6a7 | 23.75 KiB | 908.03 KiB | 884.28 KiB |
d83b35a | 23.75 KiB | 913.17 KiB | 889.42 KiB |
61414e8 | 23.75 KiB | 867.69 KiB | 843.94 KiB |
7c7ac56 | 23.75 KiB | 902.49 KiB | 878.74 KiB |
📜 Description
This PR migrates the
Lint dprint
workflow (lint-dprint-formatting.yml
) to usedorny/paths-filter
for conditional execution based on file changes. It removes theon.pull_request.paths
andon.push.paths
filters from the workflow and introduces afiles-changed
job to detect relevant modifications. Additionally, alint-dprint-required-check
job is added to serve as a reliable required check for branch protection rules.💡 Motivation and Context
This change is part of a larger effort to migrate all workflows using
on.[event].paths
filtering to afiles-changed
job usingdorny/paths-filter
. This approach improves efficiency by only running the linting process when relevant files are modified in a pull request, while still providing a consistent required check for branch protection.Fixes #5960
💚 How did you test it?
The changes are to the CI/CD workflow itself. The functionality will be verified by observing the behavior of the
Lint dprint
workflow on subsequent pull requests and pushes tomain
, ensuring it runs conditionally and the required check job functions as expected.📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.#skip-changelog