Skip to content

Conversation

philprime
Copy link
Member

📜 Description

This PR migrates the Lint dprint workflow (lint-dprint-formatting.yml) to use dorny/paths-filter for conditional execution based on file changes. It removes the on.pull_request.paths and on.push.paths filters from the workflow and introduces a files-changed job to detect relevant modifications. Additionally, a lint-dprint-required-check job is added to serve as a reliable required check for branch protection rules.

💡 Motivation and Context

This change is part of a larger effort to migrate all workflows using on.[event].paths filtering to a files-changed job using dorny/paths-filter. This approach improves efficiency by only running the linting process when relevant files are modified in a pull request, while still providing a consistent required check for branch protection.

Fixes #5960

💚 How did you test it?

The changes are to the CI/CD workflow itself. The functionality will be verified by observing the behavior of the Lint dprint workflow on subsequent pull requests and pushes to main, ensuring it runs conditionally and the required check job functions as expected.

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Open in Cursor Open in Web

#skip-changelog

@philprime philprime self-assigned this Aug 27, 2025
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.712%. Comparing base (2675d3c) to head (c89fbf7).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6002       +/-   ##
=============================================
- Coverage   86.734%   86.712%   -0.022%     
=============================================
  Files          424       424               
  Lines        36712     36712               
  Branches     17360     17359        -1     
=============================================
- Hits         31842     31834        -8     
- Misses        4823      4831        +8     
  Partials        47        47               

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2675d3c...c89fbf7. Read the comment docs.

@philprime philprime marked this pull request as ready for review August 27, 2025 17:51
cursor[bot]

This comment was marked as outdated.

@philprime philprime enabled auto-merge (squash) August 28, 2025 11:02
Copy link
Contributor

github-actions bot commented Aug 28, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.46 ms 1249.10 ms 21.65 ms
Size 23.75 KiB 928.15 KiB 904.40 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d0f70ce 1226.54 ms 1247.04 ms 20.50 ms
6279992 1213.60 ms 1241.38 ms 27.79 ms
73c9712 1238.57 ms 1260.38 ms 21.80 ms
d05d866 1211.78 ms 1230.96 ms 19.18 ms
605fa27 1226.31 ms 1251.35 ms 25.05 ms
cc7f629 1226.00 ms 1245.51 ms 19.51 ms
b41e6a7 1201.65 ms 1246.12 ms 44.47 ms
d83b35a 1212.48 ms 1237.02 ms 24.54 ms
61414e8 1225.49 ms 1254.28 ms 28.79 ms
7c7ac56 1225.90 ms 1250.22 ms 24.33 ms

App size

Revision Plain With Sentry Diff
d0f70ce 23.75 KiB 913.09 KiB 889.34 KiB
6279992 23.75 KiB 891.03 KiB 867.28 KiB
73c9712 23.75 KiB 908.01 KiB 884.26 KiB
d05d866 23.75 KiB 878.60 KiB 854.85 KiB
605fa27 23.75 KiB 908.03 KiB 884.28 KiB
cc7f629 23.75 KiB 878.48 KiB 854.73 KiB
b41e6a7 23.75 KiB 908.03 KiB 884.28 KiB
d83b35a 23.75 KiB 913.17 KiB 889.42 KiB
61414e8 23.75 KiB 867.69 KiB 843.94 KiB
7c7ac56 23.75 KiB 902.49 KiB 878.74 KiB

Previous results on branch: cursor/implement-required-checks-for-lint-dprint-c1d3

Startup times

Revision Plain With Sentry Diff
08932ca 1243.50 ms 1263.22 ms 19.72 ms

App size

Revision Plain With Sentry Diff
08932ca 23.75 KiB 928.15 KiB 904.40 KiB

@philprime philprime merged commit c6c1cb7 into main Aug 28, 2025
111 checks passed
@philprime philprime deleted the cursor/implement-required-checks-for-lint-dprint-c1d3 branch August 28, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(ci): Add required checks job for lint dprint
3 participants