Skip to content

Conversation

philprime
Copy link
Member

@philprime philprime commented Aug 27, 2025

📜 Description

Implemented the migration of the Lint CocoaPods Specs workflow (lint-cocoapods-specs.yml) from on.pull_request.paths filtering to a files-changed job using dorny/paths-filter. This includes:

  • Adding a new file filter run_lint_cocoapods_Specs_for_prs in .github/file-filters.yml.
  • Removing the paths filter from the workflow's on.pull_request.
  • Modifying the workflow to include a files-changed job, making the main lint_cocoapods_specs job conditional, and adding a lint_cocoapods_Specs-required-check job for required checks.
    This ensures the workflow runs conditionally for PRs based on file changes, but always for schedule/workflow_dispatch events, and provides a reliable required check.

💡 Motivation and Context

This change is part of a larger effort to migrate all workflows using on.[event].paths filtering to use a files-changed job with dorny/paths-filter. This approach allows for more robust required checks by introducing a dedicated job that always runs and serves as the main indicator for branch protection rules.

Fixes #5959.

See #5951 for full context on the migration strategy and #5893 for an example implementation.

💚 How did you test it?

The CI changes will be validated by observing the workflow runs on this pull request.

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Open in Cursor Open in Web

#skip-changelog

Copy link

cursor bot commented Aug 27, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@philprime philprime requested a review from itaybre as a code owner August 27, 2025 17:31
@philprime philprime changed the title Implement required checks for lint cocoapods specs chore(ci): Add required checks job for lint cocoapods specs Aug 27, 2025
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.727%. Comparing base (073562b) to head (97f968d).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6007       +/-   ##
=============================================
+ Coverage   86.672%   86.727%   +0.054%     
=============================================
  Files          424       424               
  Lines        36714     36714               
  Branches     17363     17368        +5     
=============================================
+ Hits         31821     31841       +20     
+ Misses        4846      4827       -19     
+ Partials        47        46        -1     

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073562b...97f968d. Read the comment docs.

Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@philprime philprime merged commit 029a804 into main Aug 28, 2025
50 checks passed
@philprime philprime deleted the cursor/implement-required-checks-for-lint-cocoapods-specs-9e4c branch August 28, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(ci): Add required checks job for lint cocoapods specs
3 participants