-
-
Notifications
You must be signed in to change notification settings - Fork 368
chore: Remove hang tracker sdk v9 checks #6334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6334 +/- ##
========================================
Coverage ? 86.938%
========================================
Files ? 452
Lines ? 37745
Branches ? 17466
========================================
Hits ? 32815
Misses ? 4887
Partials ? 43
Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b6f8eb3 | 1217.94 ms | 1246.57 ms | 28.63 ms |
| 8da82b4 | 1220.08 ms | 1248.24 ms | 28.16 ms |
| 37183fe | 1212.33 ms | 1238.92 ms | 26.59 ms |
| a2a3bfb | 1227.94 ms | 1261.26 ms | 33.32 ms |
| ef2c9b3 | 1222.12 ms | 1253.96 ms | 31.84 ms |
| ae79d35 | 1227.15 ms | 1252.55 ms | 25.41 ms |
| 326984b | 1235.06 ms | 1252.75 ms | 17.69 ms |
| 16f6edc | 1234.02 ms | 1269.67 ms | 35.65 ms |
| efa740d | 1220.71 ms | 1246.20 ms | 25.50 ms |
| acac774 | 1217.76 ms | 1253.29 ms | 35.52 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b6f8eb3 | 23.75 KiB | 988.70 KiB | 964.95 KiB |
| 8da82b4 | 23.75 KiB | 913.63 KiB | 889.88 KiB |
| 37183fe | 23.75 KiB | 913.63 KiB | 889.87 KiB |
| a2a3bfb | 23.75 KiB | 872.67 KiB | 848.92 KiB |
| ef2c9b3 | 23.75 KiB | 933.03 KiB | 909.29 KiB |
| ae79d35 | 23.75 KiB | 928.13 KiB | 904.38 KiB |
| 326984b | 23.74 KiB | 926.64 KiB | 902.90 KiB |
| 16f6edc | 23.74 KiB | 1022.94 KiB | 999.19 KiB |
| efa740d | 23.75 KiB | 919.69 KiB | 895.95 KiB |
| acac774 | 23.75 KiB | 866.51 KiB | 842.76 KiB |
Previous results on branch: removeHangTrackerV1
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 907b7a6 | 1216.52 ms | 1255.84 ms | 39.32 ms |
| 29de0bb | 1219.77 ms | 1260.35 ms | 40.58 ms |
| 92ec0fa | 1214.09 ms | 1247.38 ms | 33.29 ms |
| bbf9508 | 1219.44 ms | 1258.17 ms | 38.73 ms |
| 910ea04 | 1226.04 ms | 1264.50 ms | 38.46 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 907b7a6 | 23.75 KiB | 1020.98 KiB | 997.23 KiB |
| 29de0bb | 23.74 KiB | 1022.30 KiB | 998.55 KiB |
| 92ec0fa | 23.74 KiB | 1022.30 KiB | 998.55 KiB |
| bbf9508 | 23.74 KiB | 1022.29 KiB | 998.55 KiB |
| 910ea04 | 23.75 KiB | 1020.94 KiB | 997.19 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the unit tests, but please @noahsmartin also review my changes. I'm going to approve this PR, cause you can't merge if I don't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @philipphofmann this looks great
Rolls out hang tracker v2 for sdk v9
#skip-changelog
Closes #6335