-
-
Notifications
You must be signed in to change notification settings - Fork 368
chore: Remove profiling API deprecated in V9 #6386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6386 +/- ##
=============================================
- Coverage 86.996% 85.794% -1.203%
=============================================
Files 452 451 -1
Lines 37691 27328 -10363
Branches 17488 11918 -5570
=============================================
- Hits 32790 23446 -9344
+ Misses 4854 3839 -1015
+ Partials 47 43 -4
... and 410 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| afaa522 | 1234.71 ms | 1256.19 ms | 21.48 ms |
| 670b474 | 1225.33 ms | 1259.59 ms | 34.26 ms |
| 162cd7f | 1230.59 ms | 1256.76 ms | 26.16 ms |
| 9add417 | 1224.33 ms | 1243.06 ms | 18.73 ms |
| 4c719e2 | 1206.92 ms | 1237.45 ms | 30.53 ms |
| ac4739e | 1236.55 ms | 1258.89 ms | 22.34 ms |
| 3133d0e | 1237.86 ms | 1262.87 ms | 25.01 ms |
| 51f74d7 | 1236.31 ms | 1247.43 ms | 11.12 ms |
| 85a741b | 1217.02 ms | 1239.27 ms | 22.25 ms |
| 2c59847 | 1216.15 ms | 1253.80 ms | 37.65 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| afaa522 | 23.74 KiB | 996.91 KiB | 973.17 KiB |
| 670b474 | 23.75 KiB | 974.89 KiB | 951.14 KiB |
| 162cd7f | 23.75 KiB | 908.39 KiB | 884.64 KiB |
| 9add417 | 23.75 KiB | 908.40 KiB | 884.65 KiB |
| 4c719e2 | 23.75 KiB | 912.77 KiB | 889.02 KiB |
| ac4739e | 23.75 KiB | 872.67 KiB | 848.92 KiB |
| 3133d0e | 23.74 KiB | 976.79 KiB | 953.04 KiB |
| 51f74d7 | 23.74 KiB | 874.08 KiB | 850.34 KiB |
| 85a741b | 23.75 KiB | 959.44 KiB | 935.69 KiB |
| 2c59847 | 23.75 KiB | 1.00 MiB | 1005.08 KiB |
Previous results on branch: removeDeprecatedProfiling
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71bc84c | 1221.04 ms | 1261.89 ms | 40.85 ms |
| 9c83d7c | 1226.31 ms | 1255.61 ms | 29.30 ms |
| dfdec7c | 1204.65 ms | 1231.16 ms | 26.52 ms |
| d7174b5 | 1221.44 ms | 1251.22 ms | 29.79 ms |
| 5af5598 | 1229.83 ms | 1254.36 ms | 24.53 ms |
| 843566e | 1224.98 ms | 1252.87 ms | 27.89 ms |
| e1027c9 | 1236.31 ms | 1271.68 ms | 35.37 ms |
| f5e2a65 | 1217.68 ms | 1248.96 ms | 31.28 ms |
| 28fb90d | 1216.85 ms | 1250.10 ms | 33.25 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71bc84c | 23.75 KiB | 1020.85 KiB | 997.10 KiB |
| 9c83d7c | 23.75 KiB | 987.76 KiB | 964.01 KiB |
| dfdec7c | 23.75 KiB | 1.00 MiB | 1004.69 KiB |
| d7174b5 | 23.75 KiB | 1020.85 KiB | 997.10 KiB |
| 5af5598 | 23.75 KiB | 1.00 MiB | 1004.70 KiB |
| 843566e | 23.75 KiB | 1.00 MiB | 1004.44 KiB |
| e1027c9 | 23.74 KiB | 1021.80 KiB | 998.05 KiB |
| f5e2a65 | 23.75 KiB | 1020.85 KiB | 997.10 KiB |
| 28fb90d | 23.75 KiB | 1.00 MiB | 1004.89 KiB |
56f388a to
11bbfa6
Compare
11bbfa6 to
2ed0eac
Compare
2ed0eac to
808a3e8
Compare
The workflow was creating duplicate issues when multiple trigger events (opened, edited, synchronize, etc.) fired in quick succession. Both workflow runs would check the PR simultaneously, find no issue reference, and each create a new issue. Added a check to search for existing issues created by this automation before creating a new one. The workflow now searches for open issues that contain the PR URL and were created by github-actions bot, preventing duplicate issue creation. Fixes the issue where PR #6386 had two issues created (#6499 and #6500).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's so great to see so much code go. Thanks @noahsmartin. One small comment and shouldn't we add a changelog entry for that? LGTM
Removes deprecated profiling options from SentryOptions. I wanted to remove these one at a time to make the PRs smaller, but turns out they are very closely related and trying to just remove some of them made it harder to understand the PR IMO.
Most of the change is in the tests. There were a lot of tests that tested the functionality of these options that are no longer relevant so I removed them.
#skip-changelog
Closes #6500