Structured Logs: Collect stdout/stderr
per default
#6441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
stdout/stderr
and log with structured logs.💡 Motivation and Context
Just a first draft. It works in principle, so we are getting
print
andNSLog
strings as structured logs and still in console.The issue lies in infinite loops that could occur if we do internal
SentrySDKLog
call while calling structured logs. Not sure yet how to reliably handle this.Maybe @noahsmartin has some pointers for us?
Closes #6411
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.