Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Oct 21, 2025

The file SentryProfilingSwiftHelpersTests.m is part of the target SentryProfilerTests and uses @import SentryTestUtilsDynamic; but it missed it as a dependency in the target configuration.

This PR adds it as a target dependency.

#skip-changelog

Closes #6472

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.988%. Comparing base (9c75c11) to head (0811076).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6471       +/-   ##
=============================================
- Coverage   87.015%   86.988%   -0.027%     
=============================================
  Files          452       452               
  Lines        37790     37790               
  Branches     17483     17480        -3     
=============================================
- Hits         32883     32873       -10     
- Misses        4864      4875       +11     
+ Partials        43        42        -1     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c75c11...0811076. Read the comment docs.

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.98 ms 1257.77 ms 33.79 ms
Size 23.74 KiB 1022.94 KiB 999.19 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2675d3c 1218.94 ms 1239.36 ms 20.42 ms
76f74df 1238.29 ms 1261.22 ms 22.94 ms
d157d83 1228.02 ms 1252.47 ms 24.45 ms
6d40fee 1217.47 ms 1245.37 ms 27.90 ms
5218a05 1236.35 ms 1245.41 ms 9.06 ms
0ee162c 1226.90 ms 1261.72 ms 34.83 ms
09471ff 1239.98 ms 1256.65 ms 16.67 ms
75b23cd 1227.10 ms 1253.61 ms 26.51 ms
1a820a1 1217.79 ms 1260.34 ms 42.55 ms
083e8c5 1227.74 ms 1262.37 ms 34.62 ms

App size

Revision Plain With Sentry Diff
2675d3c 23.75 KiB 928.16 KiB 904.41 KiB
76f74df 23.75 KiB 879.61 KiB 855.86 KiB
d157d83 23.75 KiB 928.85 KiB 905.10 KiB
6d40fee 23.75 KiB 912.37 KiB 888.63 KiB
5218a05 23.75 KiB 984.71 KiB 960.96 KiB
0ee162c 23.75 KiB 933.33 KiB 909.58 KiB
09471ff 23.75 KiB 990.16 KiB 966.41 KiB
75b23cd 23.75 KiB 933.66 KiB 909.92 KiB
1a820a1 23.75 KiB 994.82 KiB 971.07 KiB
083e8c5 23.75 KiB 981.75 KiB 958.00 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philprime philprime merged commit e43ed75 into main Oct 21, 2025
203 of 209 checks passed
@philprime philprime deleted the philprime/fix-deps branch October 21, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Add SentryTestUtilsDynamic as dependency for SentryProfilerTests

2 participants