Skip to content

Conversation

philprime
Copy link
Member

macOS-13 runners are sunset as of November 4th 2025, therefore we need to bump runner image versions to macOS-14 and manually install simulators.

Source: https://github.blog/changelog/2025-09-19-github-actions-macos-13-runner-image-is-closing-down/

#skip-changelog

@philprime philprime self-assigned this Oct 21, 2025
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.865%. Comparing base (9c75c11) to head (28e7ae2).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6473       +/-   ##
=============================================
- Coverage   87.015%   86.865%   -0.150%     
=============================================
  Files          452       451        -1     
  Lines        37790     37649      -141     
  Branches     17483     17381      -102     
=============================================
- Hits         32883     32704      -179     
- Misses        4864      4902       +38     
  Partials        43        43               

see 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c75c11...28e7ae2. Read the comment docs.

Copy link
Contributor

github-actions bot commented Oct 21, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1191.65 ms 1218.69 ms 27.04 ms
Size 23.74 KiB 1022.75 KiB 999.01 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f8029e2 1245.16 ms 1261.32 ms 16.16 ms
15c8f13 1208.65 ms 1237.61 ms 28.97 ms
d38165b 1211.41 ms 1242.49 ms 31.08 ms
67e8e3e 1220.08 ms 1229.23 ms 9.15 ms
7d88965 1228.86 ms 1248.53 ms 19.67 ms
2481950 1221.04 ms 1248.98 ms 27.94 ms
2be5991 1228.55 ms 1264.65 ms 36.10 ms
9c75c11 1228.42 ms 1262.81 ms 34.39 ms
f0e2579 1224.82 ms 1245.49 ms 20.67 ms
87fb58a 1233.12 ms 1257.17 ms 24.04 ms

App size

Revision Plain With Sentry Diff
f8029e2 23.75 KiB 893.72 KiB 869.97 KiB
15c8f13 23.75 KiB 995.24 KiB 971.49 KiB
d38165b 23.75 KiB 855.37 KiB 831.62 KiB
67e8e3e 23.75 KiB 919.91 KiB 896.16 KiB
7d88965 23.75 KiB 994.72 KiB 970.98 KiB
2481950 23.74 KiB 872.74 KiB 849.00 KiB
2be5991 23.75 KiB 994.73 KiB 970.98 KiB
9c75c11 23.74 KiB 1022.95 KiB 999.20 KiB
f0e2579 23.75 KiB 969.22 KiB 945.47 KiB
87fb58a 23.75 KiB 919.91 KiB 896.16 KiB

Previous results on branch: philprime/macos-update

Startup times

Revision Plain With Sentry Diff
998ba9c 1194.06 ms 1215.85 ms 21.79 ms

App size

Revision Plain With Sentry Diff
998ba9c 23.74 KiB 1022.93 KiB 999.19 KiB

@philprime philprime marked this pull request as ready for review October 21, 2025 10:00
@philprime philprime enabled auto-merge (squash) October 21, 2025 10:01
cursor[bot]

This comment was marked as outdated.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we just need to rename iOS 16 to iOS 17 in the comments and the job names as pointed out in the comments.

include:
# We are running tests on iOS 17 and later, as there were OS-internal changes introduced in succeeding versions.

# iOS 16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now iOS 17 because Xcode 15.4 uses iOS 17.5 per default; see https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md#installed-sdks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct me if I am wrong, but the test job Unit iOS 16 Sentry seems to use the correct simulator:

https://github.com/getsentry/sentry-cocoa/actions/runs/18678834156/job/53259066801?pr=6473#step:7:65

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, I may be mistaken. Thanks for double-checking and ignore me.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

…tform installation. Introduce a new script for installing required platforms for Xcode 26. Update existing workflows to utilize these new parameters for improved simulator management.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants