Skip to content

Conversation

@solnic
Copy link
Collaborator

@solnic solnic commented Oct 15, 2025

DESCRIBE YOUR PR

Improves the flow and adds info about before_send_log option in the Rails' Logs section. I tried to make it flow similarly to how we have Laravel structured.


Fixes getsentry/sentry-ruby#2738

Preview

https://sentry-docs-git-rails-improve-logs-docs.sentry.dev/platforms/ruby/guides/rails/logs/

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Oct 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 16, 2025 3:00pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 16, 2025 3:00pm

@codecov
Copy link

codecov bot commented Oct 15, 2025

Bundle Report

Changes will increase total bundle size by 198 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.98MB 204 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/q2vyB1Gsa8DoWgyCRCthe/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/q2vyB1Gsa8DoWgyCRCthe/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/Uke69rePRR264WwW6tHoz/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/Uke69rePRR264WwW6tHoz/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 71 bytes 858.45kB 0.01%
../app/platform-redirect/page.js.nft.json 71 bytes 858.37kB 0.01%
../app/sitemap.xml/route.js.nft.json 71 bytes 855.6kB 0.01%

Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, looks much cleaner!

@sl0thentr0py
Copy link
Member

ah one more thing, can we also add the missing logs options in config here on the options page as well
https://sentry-docs-git-rails-improve-logs-docs.sentry.dev/platforms/ruby/guides/rails/configuration/options/

@solnic
Copy link
Collaborator Author

solnic commented Oct 16, 2025

ah one more thing, can we also add the missing logs options in config here on the options page as well
https://sentry-docs-git-rails-improve-logs-docs.sentry.dev/platforms/ruby/guides/rails/configuration/options/

@sl0thentr0py done 👇🏻

image

@solnic solnic force-pushed the rails/improve-logs-docs branch from 5078ee2 to 679bc75 Compare October 16, 2025 14:30
@solnic solnic merged commit 1ad61e4 into master Oct 16, 2025
13 checks passed
@solnic solnic deleted the rails/improve-logs-docs branch October 16, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User Feedback: Rails logging docs are over-complex and lack flow

2 participants