Skip to content

Conversation

limbonaut
Copy link
Collaborator

DESCRIBE YOUR PR

After we migrated to using SdkOption instead of ConfigKey, links to specific options broke in the Godot SDK. This PR fixes the links that I found broken.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Oct 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 15, 2025 9:12pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 15, 2025 9:12pm

@codeowner-assignment codeowner-assignment bot requested a review from a team October 15, 2025 15:29
@limbonaut limbonaut marked this pull request as ready for review October 15, 2025 15:34
Copy link

codecov bot commented Oct 15, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.98MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
server/middleware-*.js -6.46kB 1.0kB -86.59%
static/lWl7YjBB95AW0gkXftQ3L/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/lWl7YjBB95AW0gkXftQ3L/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/DENQn3_a-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/DENQn3_a-*.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️

@sfanahata
Copy link
Contributor

@limbonaut - good catch on these! I just ran through the other platforms where this would be an issue and have a PR I'm working on deploying to fix the rest.

@limbonaut
Copy link
Collaborator Author

It's a bit confusing now, with sections being kebab-case, and options snake_case 😅 but I'll survive

@sfanahata
Copy link
Contributor

Fair! I don't know why it's not working with the change to snake_case, but I can dig into that another time.

Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@limbonaut - I know why Programmatic Configuration is different! That's an option category header, not an option. Looks good in the preview, so going to merge. Thanks again!

@sfanahata sfanahata merged commit fa0e8b2 into master Oct 16, 2025
13 checks passed
@sfanahata sfanahata deleted the godot-fix-option-links branch October 16, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants