-
-
Couldn't load subscription status.
- Fork 225
Session Replay for iOS #4664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jamescrosswell
wants to merge
9
commits into
version6
Choose a base branch
from
ios-replay
base: version6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+95
−9
Draft
Session Replay for iOS #4664
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5044bb2
Added ability to set ReplayOptions for Cocoa
jamescrosswell faa8955
Added SentryReplayOptions constructor
jamescrosswell 2b38e74
Simplify replay options setup
jamescrosswell 34308e1
Enable session tracking (required) in Cocoa when session replay is en…
jamescrosswell fd44770
change log
jamescrosswell 24a1894
Associate replays with exceptions
jamescrosswell d932572
Fixed compilation error
jamescrosswell 7e1ef56
Merge remote-tracking branch 'origin/version6' into ios-replay
jamescrosswell 241d0d8
Updated bindings
jamescrosswell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how we now want to handle situations like this:
sentry-dotnet/src/Sentry/SentryClient.cs
Lines 350 to 362 in 9d1b4fe
... or this:
sentry-dotnet/src/Sentry/Internal/Hub.cs
Lines 376 to 384 in 9d1b4fe
If the CocoaSdk owns the session, do we still need to be able to start/stop sessions from the .NET SDK?