Skip to content

Conversation

ribice
Copy link
Collaborator

@ribice ribice commented Jan 25, 2025

Resolves #340
Closes GO-12

TODO:

@ribice ribice requested a review from cleptric January 25, 2025 19:18
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 57.37052% with 107 lines in your changes missing coverage. Please review.

Project coverage is 82.41%. Comparing base (2e92c62) to head (7e3c24e).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
zap/core.go 45.94% 65 Missing and 15 partials ⚠️
zap/sentryzap.go 63.82% 16 Missing and 1 partial ⚠️
zap/field.go 0.00% 4 Missing ⚠️
zap/frame_matcher.go 71.42% 4 Missing ⚠️
zap/util.go 94.73% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #958      +/-   ##
==========================================
- Coverage   83.63%   82.41%   -1.23%     
==========================================
  Files          49       54       +5     
  Lines        5139     5390     +251     
==========================================
+ Hits         4298     4442     +144     
- Misses        684      775      +91     
- Partials      157      173      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aliBordbar1992
Copy link

hey
is this PR expected to be merged in near future?
or is it recommended to switch to another supported logging library that is already integrated with sentry?

@giortzisg
Copy link
Contributor

Hey @aliBordbar1992,
The PR only includes issue events and not logs, so it stills needs additional work. I would say for now it's better to switch to one of the supported integrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration with zap logging library
5 participants