Skip to content

feat(browser): Handles data URIs in chrome stack frames #17292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2025

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Aug 3, 2025

This PR copies what we did for Node (#17218) but for the Chromium stack parser.

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Aug 3, 2025

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 24.04 kB +0.22% +51 B 🔺
@sentry/browser - with treeshaking flags 22.61 kB +0.21% +46 B 🔺
@sentry/browser (incl. Tracing) 39.74 kB +0.14% +53 B 🔺
@sentry/browser (incl. Tracing, Replay) 77.85 kB +0.07% +49 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.69 kB +0.07% +41 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 82.55 kB +0.07% +54 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 94.65 kB +0.07% +60 B 🔺
@sentry/browser (incl. Feedback) 40.69 kB +0.11% +42 B 🔺
@sentry/browser (incl. sendFeedback) 28.7 kB +0.18% +50 B 🔺
@sentry/browser (incl. FeedbackAsync) 33.59 kB +0.14% +44 B 🔺
@sentry/react 25.76 kB +0.19% +47 B 🔺
@sentry/react (incl. Tracing) 41.69 kB +0.17% +69 B 🔺
@sentry/vue 28.5 kB +0.17% +47 B 🔺
@sentry/vue (incl. Tracing) 41.56 kB +0.14% +58 B 🔺
@sentry/svelte 24.06 kB +0.21% +49 B 🔺
CDN Bundle 25.54 kB +0.18% +45 B 🔺
CDN Bundle (incl. Tracing) 39.62 kB +0.12% +47 B 🔺
CDN Bundle (incl. Tracing, Replay) 75.69 kB +0.09% +65 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 81.09 kB +0.05% +38 B 🔺
CDN Bundle - uncompressed 74.67 kB +0.14% +102 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 117.28 kB +0.09% +102 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 231.55 kB +0.05% +102 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 244.15 kB +0.05% +102 B 🔺
@sentry/nextjs (client) 43.74 kB +0.1% +42 B 🔺
@sentry/sveltekit (client) 40.19 kB +0.14% +53 B 🔺
@sentry/node-core 47.72 kB - -
@sentry/node 146.61 kB - -
@sentry/node - without tracing 91.82 kB - -
@sentry/aws-serverless 103.27 kB - -

View base workflow run

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge after we address the at dynamicFn stuff

@AbhiPrasad AbhiPrasad merged commit aab4276 into develop Aug 5, 2025
357 of 361 checks passed
@AbhiPrasad AbhiPrasad deleted the timfish/feat/chrome-data-uri branch August 5, 2025 17:05
RulaKhaled pushed a commit that referenced this pull request Aug 7, 2025
This PR copies what we did for Node (#17218) but for the Chromium stack
parser.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants