feat(metrics): introduce metrics #1968
Open
+1,071
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Litarnus
commented
Nov 20, 2025
cleptric
reviewed
Nov 20, 2025
| string $key, | ||
| float $value, | ||
| ?MetricsUnit $unit = null, | ||
| ?Unit $unit = null, |
Member
There was a problem hiding this comment.
Suggested change
| ?Unit $unit = null, | |
| ?MetricsUnit $unit = null, |
stayallive
reviewed
Nov 23, 2025
Collaborator
stayallive
left a comment
stayallive
left a comment
There was a problem hiding this comment.
Code wise the looks good (especially much love for the RingBuffer).
The only thing I'm worried about a bit is that we modify the existing code, namely MetricsUnit and some parameters which is a backwards incompatible break for people that did not yet cleanup their code after we deprecated the previous metrics iteration. Do we feel like that is an acceptable risk? If this is going in 5.x this is a non-issue but the target is master so hence my ask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing metrics for PHP!
Metrics have 3 supported types
Each of those metrics can be submitted by calling
\Sentry\metrics()->count('test-counter', 1, ['tag' => 'foo'])It's also possible to attach units:
\Sentry\metrics()->gauge('test-gauge', 10, ['tag' => 'foo'], \Sentry\Metrics\Unit::second())Up to 1000 metrics can be stored per request. Older metrics are dropped when the limit is reached.
Metrics need to be flushed manually by calling
\Sentry\metrics()->flush().