Skip to content

Conversation

@sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Oct 1, 2025

  • setup external propagation context to fetch trace_id/span_id from otel
  • setup otlp exporter with endpoint and headers taken from DSN
  • setup propagator
  • exporter and propagator are setup by default, can be turned off in case people want to setup manually

Issues

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 90.56604% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.01%. Comparing base (9b497d7) to head (cf6078d).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/otlp.py 90.38% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4877      +/-   ##
==========================================
+ Coverage   83.96%   84.01%   +0.04%     
==========================================
  Files         179      180       +1     
  Lines       17951    18004      +53     
  Branches     3194     3200       +6     
==========================================
+ Hits        15073    15126      +53     
  Misses       1906     1906              
  Partials      972      972              
Files with missing lines Coverage Δ
sentry_sdk/consts.py 99.40% <100.00%> (+<0.01%) ⬆️
sentry_sdk/integrations/otlp.py 90.38% <90.38%> (ø)

... and 2 files with indirect coverage changes

@sl0thentr0py sl0thentr0py force-pushed the neel/poc-otlp-integration branch 11 times, most recently from 726b769 to f5923b2 Compare October 31, 2025 15:31
@sl0thentr0py sl0thentr0py changed the title POC OtlpIntegration OTLPIntegration Oct 31, 2025
@sl0thentr0py sl0thentr0py force-pushed the neel/poc-otlp-integration branch from f5923b2 to 525bd76 Compare October 31, 2025 15:34
@linear
Copy link

linear bot commented Oct 31, 2025

@sl0thentr0py
Copy link
Member Author

sl0thentr0py commented Oct 31, 2025

sentry error + sentry log + otlp trace

2025-10-31-162117_hyprshot

@sl0thentr0py sl0thentr0py force-pushed the neel/poc-otlp-integration branch 4 times, most recently from beb8ce0 to 6d60191 Compare November 5, 2025 15:56
@sl0thentr0py sl0thentr0py marked this pull request as ready for review November 5, 2025 16:07
@sl0thentr0py sl0thentr0py requested a review from a team as a code owner November 5, 2025 16:07
@sl0thentr0py
Copy link
Member Author

distributed tracing also works 🎉

image

Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few questions just so I understand what's going on better as well.

Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sl0thentr0py sl0thentr0py force-pushed the neel/poc-otlp-integration branch from 75c4163 to dbf5ad9 Compare November 12, 2025 15:20
@sl0thentr0py sl0thentr0py force-pushed the neel/poc-otlp-integration branch from dbf5ad9 to cf6078d Compare November 12, 2025 15:42
@sl0thentr0py sl0thentr0py enabled auto-merge (squash) November 12, 2025 15:44
@sl0thentr0py sl0thentr0py merged commit b8a0db2 into master Nov 12, 2025
141 of 143 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/poc-otlp-integration branch November 12, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement OtlpIntegration for Python SDK

4 participants